Skip to content

Div mul fusion - #7183

Merged
ashbhandare merged 3 commits into
masterfrom
aibhanda/div_mul
Apr 5, 2021
Merged

ashbhandare merged 3 commits into
masterfrom
aibhanda/div_mul

Conversation

@ashbhandare

Copy link
Copy Markdown
Contributor

This transform fuses Div->Mul when the computation is (1/X1 * X2) to do Div (X2/X1)

@ashbhandare
ashbhandare requested a review from a team as a code owner March 30, 2021 19:00
Comment thread onnxruntime/core/optimizer/div_mul_fusion.cc Outdated
Comment thread onnxruntime/core/optimizer/div_mul_fusion.cc
Comment thread onnxruntime/core/optimizer/div_mul_fusion.cc Outdated
Comment thread onnxruntime/core/optimizer/div_mul_fusion.cc Outdated
Comment thread onnxruntime/test/optimizer/graph_transform_test.cc Outdated
Comment thread onnxruntime/core/optimizer/div_mul_fusion.h Outdated
Comment thread orttraining/orttraining/core/optimizer/graph_transformer_utils.cc Outdated
@ashbhandare ashbhandare added the training issues related to ONNX Runtime training; typically submitted using template label Mar 30, 2021
@ashbhandare
ashbhandare force-pushed the aibhanda/div_mul branch 2 times, most recently from 8858f7e to e284fd5 Compare March 31, 2021 23:50
Comment thread onnxruntime/core/optimizer/div_mul_fusion.cc
@fdwr

Copy link
Copy Markdown
Contributor

Amusingly, many GPU's then (internally) decompose X2/X1 back into (1/X1 * X2). 😅

@ashbhandare
ashbhandare merged commit 2b85135 into master Apr 5, 2021
@ashbhandare
ashbhandare deleted the aibhanda/div_mul branch April 5, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

training issues related to ONNX Runtime training; typically submitted using template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants