Repository navigation
[TraceEvent] Extend RuntimeSku to recognize Mono - #1658
Merged
Brian Robbins (brianrob) merged 1 commit intoJul 6, 2022
Merged
Brian Robbins (brianrob) merged 1 commit into
Brian Robbins (brianrob) merged 1 commit into
Conversation
Contributor
Author
Brian Robbins (brianrob)
approved these changes
Jul 5, 2022
Brian Robbins (brianrob)
left a comment
Brian Robbins (brianrob)
left a comment
Member
There was a problem hiding this comment.
LGTM. Once the runtime change is merged, let me know and I'll merge this.
Contributor
Author
|
Brian Robbins (@brianrob) dotnet/runtime#71657 is now merged! |
Mitchell Hwang (mdh1418)
deleted the
extend_traceevent_parser_with_runtimesku_mono
branch
July 6, 2022 23:41
This was referenced Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dotnet/runtime, dotnet/runtime#71657 and dotnet/runtime#71359 extend RuntimeSku in EventTrace to recognize Mono runtime as
0x4. Adding the same extension here so that the value shows up asMonoinstead of4.