Discuss new NetTrace V6 format - #2170

Merged

Jiri Cincura ↹ (cincuranet) merged 29 commits into

microsoft:mainfrom

noahfalk:nettrace_v6

Mar 31, 2025

Commits on Mar 21, 2025

Discuss new NetTrace V6 format
Noah Falk (noahfalk)
committed
b4448a4
Adding a KeyValue optional metadata item for events
Noah Falk (noahfalk)
committed
1e3f5f9
Adding a KeyValue pairs for TraceBlock
Noah Falk (noahfalk)
committed
b30f6e5
Refactor EventPipeEventSource
Noah Falk (noahfalk)
committed
357d307
Add initial V6 format parsing
Noah Falk (noahfalk)
committed
2b186c5
Refactor a bunch of unsafe pointer reading to use SpanReader
Noah Falk (noahfalk)
committed
c7fcd2d
Refactor metadata parsing code to use property setters
Noah Falk (noahfalk)
committed
526b641
More metadata refactoring
Noah Falk (noahfalk)
committed
09b887c
Stop translating file format versions into a separate metadata version
Noah Falk (noahfalk)
committed
b0fcbfe
Extract ReadMetadata()
Noah Falk (noahfalk)
committed
6375ec2
Consolidate the metadata transform/canonicalization steps separate from the format specific parsing
Noah Falk (noahfalk)
committed
be8c3ad
Use SpanReader for metadata reading
Noah Falk (noahfalk)
committed
667bcff
Stop using ReadAndDispatchEvent in metadata block parsing for its side-effects of caching metadata. Instead be explicit.
Noah Falk (noahfalk)
committed
3227683
Yet more refactoring
Noah Falk (noahfalk)
committed
b0e9150
Align naming on EventPipeXYZ
Noah Falk (noahfalk)
committed
00a11e2
Pull the metadata parsing logic into EventPipeMetadata class and stick in a separate file
Noah Falk (noahfalk)
committed
a0012fc
Adding more tests on the V5 format to make sure my refactoring didn't break extensibility points
Noah Falk (noahfalk)
committed
ffc2670
Add some V6 extensibility tests and fix the reader to skip over unknown block types
Noah Falk (noahfalk)
committed
f9c5c38
Implement most of V6 metadata parsing and tests
Noah Falk (noahfalk)
committed
c221ee1
Add support for varint and length-prefixed strings
Noah Falk (noahfalk)
committed
f4d987e
Add ThreadBlock, RemoveThreadBlock, V6 event parsing and populating process Id information on events
Noah Falk (noahfalk)
committed
30de9b4
Tweak optional metadata encoding
Noah Falk (noahfalk)
committed
6a11e88
Added the label list block
Noah Falk (noahfalk)
committed
459b089
Updating the docs so that NetTrace V6 is now described on its own rather than relative to V5.
Noah Falk (noahfalk)
committed
91bd894

Commits on Mar 23, 2025

Commits on Mar 26, 2025

Fix bug that wasn't reseting StackBytes for V6 events that have no stack
Noah Falk (noahfalk)
committed
f6f8f8d

Navigation Menu

Discuss new NetTrace V6 format - #2170

Discuss new NetTrace V6 format#2170
Jiri Cincura ↹ (cincuranet) merged 29 commits into
microsoft:mainfrom
noahfalk:nettrace_v6

Commits on Mar 21, 2025

Discuss new NetTrace V6 format

Adding a KeyValue optional metadata item for events

Adding a KeyValue pairs for TraceBlock

Refactor EventPipeEventSource

Add initial V6 format parsing

Refactor a bunch of unsafe pointer reading to use SpanReader

Refactor metadata parsing code to use property setters

More metadata refactoring

Stop translating file format versions into a separate metadata version

Extract ReadMetadata()

Consolidate the metadata transform/canonicalization steps separate from the format specific parsing

Use SpanReader for metadata reading

Stop using ReadAndDispatchEvent in metadata block parsing for its side-effects of caching metadata. Instead be explicit.

Yet more refactoring

Align naming on EventPipeXYZ

Pull the metadata parsing logic into EventPipeMetadata class and stick in a separate file

Adding more tests on the V5 format to make sure my refactoring didn't break extensibility points

Add some V6 extensibility tests and fix the reader to skip over unknown block types

Implement most of V6 metadata parsing and tests

Add support for varint and length-prefixed strings

Add ThreadBlock, RemoveThreadBlock, V6 event parsing and populating process Id information on events

Tweak optional metadata encoding

Added the label list block

Updating the docs so that NetTrace V6 is now described on its own rather than relative to V5.

Commits on Mar 23, 2025

Fix ValidateStackFields after the rebase

Revert back to the V5 compressed header behavior for ThreadIndex

Unit test refactoring - Embed format version into a more strongly typed EventPipeWriter so that it doesn't need to replicated in every method call

- Added support for the optional flush all threads flag on the sequence point

Commits on Mar 26, 2025

Fix bug that wasn't reseting StackBytes for V6 events that have no stack