Repository navigation
Validate Serialized String Lengths Before Allocation - #2474
Merged
Brian Robbins (brianrob) merged 1 commit intoOct 6, 2026
Merged
Brian Robbins (brianrob) merged 1 commit into
Brian Robbins (brianrob) merged 1 commit into
Conversation
Lee Culver (leculver)
approved these changes
Oct 6, 2026
Brian Robbins (brianrob)
enabled auto-merge (squash)
October 6, 2026 15:34
This was referenced Oct 14, 2026
This was referenced Oct 15, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed serialized input can cause
ReadString()to allocate excessive memory from an untrusted character count before detecting truncated content.Validate string counts before allocating or resetting the builder: accept only
-1as null, reject other negative counts, and check against remaining bytes when the stream length is known. Known-length readers preallocate the validated count; non-seekable readers use a bounded initial capacity and grow as content is decoded. The existing wire format is unchanged.Add regression coverage for oversized and invalid counts, non-seekable allocation behavior, malformed type names, truncated characters, and compatibility with valid strings.