Fix df.signal not propagated into child sub-orchestrations - #154
Merged
Pino de Candia (pinodeca) merged 2 commits intoMay 22, 2026
Conversation
…erage Agent-Logs-Url: https://github.com/microsoft/pg_durable/sessions/01258fe7-d415-4f63-95f4-9493c797fa20 Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
Copilot stopped work on behalf of
Pino de Candia (pinodeca) due to an error
May 19, 2026 22:41
Pino de Candia (pinodeca)
marked this pull request as ready for review
May 22, 2026 20:10
Contributor
|
Review followups from the deep-dive on this change. Filing them here so they aren't lost; all are intentionally deferred — either because they're properly solved by the upstream duroxide fix tracked in microsoft/duroxide#21, or because they're polish that doesn't gate this PR.
Filed microsoft/duroxide#21 to request the upstream primitive (unmatched-event forwarding or an explicit |
Pino de Candia (pinodeca)
deleted the
copilot/fix-signal-propagation-issue
branch
May 22, 2026 20:21
Pino de Candia (pinodeca)
added a commit
that referenced
this pull request
Jun 29, 2026
Tests 1, 3, 4, and 5 sent a single fire-once signal after a fixed
pg_sleep. duroxide drops any external event raised before the
wait_for_signal subscription is registered ("no pending subscription
slot", duroxide #154), so under CI/load the signal could land before
the subscription exists and the workflow would wait out its timeout,
causing df.await_instance to time out (status: running).
Replace the fixed-sleep + fire-once pattern with a retry loop that
re-raises the signal while the instance is still 'running' and stops
once it leaves that state, guaranteeing at least one signal lands after
the subscription is registered. Checking status before each send avoids
signaling an already-completed instance.
Verified with 10 consecutive repeats:
./scripts/test-e2e-local.sh 07_signals 10 -> 10 passed, 0 failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.