Repository navigation
fix(chromium): throw explicit error for evicted non-refetchable response bodies - #42966
Closed
Hardik K (hardikkaurani) wants to merge 2 commits into
Closed
Hardik K (hardikkaurani) wants to merge 2 commits into
Hardik K (hardikkaurani) wants to merge 2 commits into
Conversation
Author
|
Yury Semikhatsky (@yury-s) The requested changes for #42862 are in place, including the regression coverage for evicted non-refetchable response bodies. When you have a chance, could you please take another look at the latest revision? Thanks! |
Collaborator
|
This is a breaking change, we don't want this. Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42862.
When a response body is evicted from the CDP cache and it is unsafe to refetch (e.g. it is a \ etch\ GET), Chromium's network manager would silently return an empty 0-byte buffer (\Buffer.from('')). This breaks explicit
esponse.body()\ calls when the page itself already consumed the response (e.g. via .blob()), as developers received 0 bytes without any clear indication of why.
As discussed in #42862, silently failing and returning 0 bytes is incorrect. Re-fetching a \ etch\ GET is also unsafe since it produces server side-effects (e.g. invalidating single-use tokens, as noted in PR #42863).
This PR throws a clear, explicit Error (\Response body is unavailable for evicted resources) instead of returning an empty buffer when a re-fetch is disallowed.
Testing