Repository navigation
Pull Pylance with Pyright 1.1.414 - #11949
Heejae Chang (heejaechang) wants to merge 1 commit into
Conversation
Co-authored-by: Bill Schnurr <bschnurr@microsoft.com> Co-authored-by: HeeJae Chang <hechang@microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@microsoft.com> Co-authored-by: Stella Huang <stellahuang@microsoft.com>
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Please add focused test coverage for Partially bind one, several, and all elements of an unpacked fixed-tuple parameter; assert remaining arguments are accepted and incorrect types or arities produce diagnostics. |
Please add focused test coverage for Generate and reanalyze partial stubs covering retained overloads, generic identity, same-spelling TypeVars from distinct overload scopes, and nested Unknown versus Any; assert reconstructed call results preserve the original types. |
Please add focused test coverage for Query a partial instance and its bound call; assert both use synthesized protocol representations and retain the transformed remaining signature rather than the original declaration. |
|
Result: Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: All 56 targeted existing tests passed, including partial-call, annotation-modifier, stub-generation, and type-server checks. Package TypeScript checking also passed after offline dependency preparation. The PR adds no tests, and existing coverage does not exercise its new partial reconstruction paths or fixed-tuple trimming. A temporary reviewer round-trip test failed to compile because of a reviewer-written API misuse; it established no PR defect. Those specific regression gaps remain unverified. **Reviewer dependency follow-up (nonblocking):** Suggest a separate PR adding `jest@^30.2.0`, `ts-jest@^29.4.7`, `typescript@~6.0.3` to the official reviewer dependency declarations, using `packages/pyright-internal/package.json` as the dependency/version evidence. Do not automatically create that PR. This is reviewer environment maintenance, not a required change to the reviewed PR. Test runs: 4 passed, 1 failed, 1 not run
|
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Compared candidate View the full release history charts with the base and PR results. Execution time historyPeak memory historyType checker benchmark🟢 No performance regressions detected. Regression threshold:
Pyright stats
|
Synchronizes Pylance compatibility changes with the current Pyright codebase.
Rollup:
REVIEWER: Review only Pyright/Pylance synchronization and compatibility changes in this PR; do not leave unrelated feedback.