Repository navigation
Fix generator expressions in typed list literals - #11950
Open
Guishi Wang (guishiw) wants to merge 1 commit into
Open
Guishi Wang (guishiw) wants to merge 1 commit into
Guishi Wang (guishiw) wants to merge 1 commit into
Conversation
Collaborator
🟢 Pyright CLI QA —
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #11841
Root cause
The expected-type path for list and set literals treated every comprehension parse node as a container comprehension. A parenthesized generator expression uses the same parse-node kind, so Pyright checked its yielded element type instead of checking the generator object as a list element.
Fix strategy
Exclude generator expressions from the comprehension-specific expected-type path and evaluate them as ordinary expressions. Add a regression case to the existing list literal sample.
The relevant test suite passes with 176 tests.