Skip to content

Replace ContextContainer::Shared with std::shared_ptr<const ContextContainer>#14975

Merged
iamAbhi-916 merged 5 commits into
microsoft:mainfrom
christophpurrer:ContextContainerShared
Jul 30, 2025
Merged

Replace ContextContainer::Shared with std::shared_ptr<const ContextContainer>#14975
iamAbhi-916 merged 5 commits into
microsoft:mainfrom
christophpurrer:ContextContainerShared

Conversation

@christophpurrer

@christophpurrer christophpurrer commented Jul 28, 2025 •
edited by microsoft-github-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This existing alias is deprecated. See: react/react-native#52889

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

The existing/old alias will eventually be deleted

What

No functional change

Screenshots

N/A

Testing

CI jobs

Changelog

no_

Microsoft Reviewers: Open in CodeFlow

@christophpurrer christophpurrer requested a review from a team as a code owner July 28, 2025 20:51
@vineethkuttan

vineethkuttan commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

/azp run

@vineethkuttan vineethkuttan self-assigned this Jul 29, 2025
@azure-pipelines

azure-pipelines Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 2 pipeline(s).

@vineethkuttan

vineethkuttan commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @christophpurrer

You are facing linting issues
i) Run yarn format and yarn lint:fix and the commit the formatted changes.

Guidelines point 6

@jonthysell

jonthysell commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

/azp run PR

@azure-pipelines

azure-pipelines Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 1 pipeline(s).

@jonthysell

jonthysell commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Hi @christophpurrer

You are facing linting issues i) Run yarn format and yarn lint:fix and the commit the formatted changes.

Guidelines point 6

@vineethkuttan Something else to look out for when reviewing PRs are correct change files - this PR is only changing files for the react-native-windows package, so it only needs the change file for that single package. And for that particular package, it also needed to be:

  "type": "prerelease",
  "dependentChangeType": "patch"

Not the "none" it was before. We never use "none". I removed all of the unnecessary change files - it doesn't look like our PR checks were blocking them.

@christophpurrer

christophpurrer commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @jonthysell > It seems you have fixed my formatting errors.
I'll keep those instructions in mind for the next PR

iamAbhi-916
iamAbhi-916 approved these changes Jul 30, 2025
View reviewed changes

@iamAbhi-916 iamAbhi-916 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamAbhi-916 iamAbhi-916 merged commit 6f9dbbe into microsoft:main Jul 30, 2025
58 checks passed
anupriya13 pushed a commit to anupriya13/react-native-windows that referenced this pull request Jul 31, 2025
@christophpurrer @jthysell @anupriya13
Replace ContextContainer::Shared with std::shared_ptr<const ContextCo…
9ed27ee 
…ntainer> (microsoft#14975)

* Replace ContextContainer::Shared with std::shared_ptr<const ContextContainer>

This existing alias is deprecated now.

See: : react/react-native#52889

* Change files

* Fix change files

* fix formatting

---------

Co-authored-by: Jon Thysell <jthysell@microsoft.com>
@anupriya13 anupriya13 mentioned this pull request Jul 31, 2025
Merged
anupriya13 added a commit that referenced this pull request Jul 31, 2025
@anupriya13 @christophpurrer @jthysell
Replace ContextContainer::Shared with std::shared_ptr<const ContextCo…
c043a15 
…ntainer> (#14975) (#14990)

* Replace ContextContainer::Shared with std::shared_ptr<const ContextContainer>

This existing alias is deprecated now.

See: : react/react-native#52889

* Change files

* Fix change files

* fix formatting

---------

Co-authored-by: Christoph Purrer <chpurrer@meta.com>
Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vineethkuttan vineethkuttan vineethkuttan approved these changes
@iamAbhi-916 iamAbhi-916 iamAbhi-916 approved these changes

Assignees

@vineethkuttan vineethkuttan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christophpurrer @vineethkuttan @jonthysell @iamAbhi-916 @jthysell