Repository navigation
[0.64] Fix MSBuild Bundling When Path Contains Spaces - #7678
Merged
Nick Gerleman (NickGerleman) merged 6 commits intoMay 20, 2021
Merged
Nick Gerleman (NickGerleman) merged 6 commits into
Nick Gerleman (NickGerleman) merged 6 commits into
Conversation
Fixes microsoft#7597 We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces.
ghost
added
Nick Gerleman (NickGerleman)
requested review from
acoates-ms and
Jon Thysell (jonthysell)
April 28, 2021 15:26
Danny van Velzen (dannyvv)
approved these changes
Apr 28, 2021
Jon Thysell (jonthysell)
approved these changes
May 3, 2021
acoates-ms
approved these changes
May 18, 2021
Chris Glein (chrisglein)
approved these changes
May 18, 2021
|
Still not working for me 0.65 just building a new project has become a nightmare, I've tried linking my User folder to one without a space, overwriting my $env:LOCALAPPDATA in powershell and all kinds of tricks. It doesn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7597
We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces.
Backporting to 0.64 due to internal partner ask.
Microsoft Reviewers: Open in CodeFlow