Skip to content

.Net: Sync to MEAI 9.3.0-preview.1.25114.11 - #10989

Merged
Mark Wallace (markwallace-microsoft) merged 2 commits into
microsoft:mainfrom
roji:NewMEAI
Mar 18, 2025
Merged

.Net: Sync to MEAI 9.3.0-preview.1.25114.11#10989
Mark Wallace (markwallace-microsoft) merged 2 commits into
microsoft:mainfrom
roji:NewMEAI

Conversation

@roji

@roji Shay Rojansky (roji) commented Mar 14, 2025

Copy link
Copy Markdown
Member

A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below.

@roji
Shay Rojansky (roji) requested a review from a team as a code owner March 14, 2025 20:50
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 14, 2025
@github-actions github-actions Bot changed the title Sync to MEAI 9.3.0-preview.1.25114.11 .Net: Sync to MEAI 9.3.0-preview.1.25114.11 Mar 14, 2025
roji
Shay Rojansky (roji) commented Mar 14, 2025
View reviewed changes
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceExtensions.cs
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatClientChatCompletionService.cs
Comment thread dotnet/src/SemanticKernel.UnitTests/AI/ServiceConversionExtensionsTests.cs Outdated
@stephentoub

Stephen Toub (stephentoub) commented Mar 14, 2025

Copy link
Copy Markdown
Member

Sync to MEAI 9.3.0-preview.1.25114.11

Thanks! You beat me to it. I was waiting for a new build of ONNXRuntimeGenAI to be available, as I expect there will be versioning issues without that. It's supposed to be out today.

stephentoub
Stephen Toub (stephentoub) reviewed Mar 14, 2025
View reviewed changes
Comment thread dotnet/Directory.Packages.props
roji
Shay Rojansky (roji) commented Mar 14, 2025
View reviewed changes
Comment thread dotnet/src/SemanticKernel.Abstractions/Contents/KernelContent.cs Outdated
rogerbarreto
Roger Barreto (rogerbarreto) reviewed Mar 14, 2025
View reviewed changes
Comment thread dotnet/src/SemanticKernel.Abstractions/Contents/BinaryContent.cs Outdated
Merged
@stephentoub

Stephen Toub (stephentoub) commented Mar 15, 2025

Copy link
Copy Markdown
Member

Mark Wallace (@markwallace-microsoft), Roger Barreto (@rogerbarreto), are there known issues with the Process tests? I'm not familiar with that part of the codebase, but it's not clear to me why it would be impacted at all by the changes in this PR.

rogerbarreto
Roger Barreto (rogerbarreto) reviewed Mar 15, 2025
View reviewed changes
Comment thread dotnet/Directory.Packages.props Outdated
@rogerbarreto

Roger Barreto (rogerbarreto) commented Mar 15, 2025

Copy link
Copy Markdown
Member

are there known issues with the Process tests? I'm not familiar with that part of the codebase

I saw that, will have a look, thought the same

rogerbarreto
Roger Barreto (rogerbarreto) reviewed Mar 18, 2025
View reviewed changes
Comment thread dotnet/Directory.Packages.props Outdated
rogerbarreto
Roger Barreto (rogerbarreto) approved these changes Mar 18, 2025
View reviewed changes
Comment thread dotnet/samples/Concepts/Plugins/CreatePluginFromOpenApiSpec_Github.cs
@stephentoub

Stephen Toub (stephentoub) commented Mar 18, 2025

Copy link
Copy Markdown
Member

The PR is building now. We should definitely revisit the 512e76b commit, though, after today's release is unblocked. It seems like there's some kind of conflict in the OllamaSharp package due to it carrying a source generator that depends on versions of compiler binaries that are incompatible with other aspect's of the repo's build. This was the way I found to temporarily work around it (other things I tried like excluding the analyzer assets for OllamaSharp were insufficient), but I don't like it as a longer-term solution.

Merged via the queue into microsoft:main with commit ea00f4f Mar 18, 2025
@roji
Shay Rojansky (roji) deleted the NewMEAI branch March 18, 2025 16:31
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
@roji @stephentoub Javier
.Net: Sync to MEAI 9.3.0-preview.1.25114.11 (microsoft#10989)
0a27365 
A good review would be much appreciated, including considering the
higher-level implications of the MEAI-side change for SK (I know very
little about SK outside of MEVD!). See specific comments below.

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub Stephen Toub (stephentoub) stephentoub left review comments
@rogerbarreto Roger Barreto (rogerbarreto) rogerbarreto approved these changes
+2 more reviewers
@azchohfi Alexandre Zollinger Chohfi (azchohfi) azchohfi left review comments
@markwallace-microsoft Mark Wallace (markwallace-microsoft) markwallace-microsoft approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoub Stephen Toub (stephentoub)

Labels

kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roji @stephentoub @rogerbarreto @azchohfi @markwallace-microsoft