.Net: Update KernelFunctionInvokingChatClient as a specialization of MEAI.FunctionInvokingChatClient - #11678
Merged
Roger Barreto (rogerbarreto) merged 29 commits intoMay 6, 2025
Conversation
…a specialization of it
…lated update changes needed
Roger Barreto (rogerbarreto)
added
the
msft.ext.ai
Roger Barreto (rogerbarreto)
requested a review
from Stephen Toub (stephentoub)
April 22, 2025 16:31
Mark Wallace (markwallace-microsoft)
added
.NET
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
April 22, 2025 16:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
April 22, 2025 16:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Roger Barreto (rogerbarreto)
moved this from Sprint: In Review
to Bug
in Semantic Kernel
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
April 22, 2025 20:22 — with
GitHub Actions
Error
GitHub Actions
Error
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
April 22, 2025 20:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Jeff Handley (jeffhandley)
left a comment
Jeff Handley (jeffhandley)
left a comment
Member
There was a problem hiding this comment.
Roger Barreto (@RogerBarret0) I left several comments for us to consider with Steve Sanderson (@SteveSandersonMS).
Even if we don't make changes into MEAI GA for the possible API additions, the approach you've taken here to refactor the replacement classes out to keep the Kernel* classes more maintainable seems reasonable to me.
You also mentioned a middleware-type concept when we chatted, but I didn't spot where that was surfacing in here. Can you explain that again and/or draw my attention to it please?
Roger Barreto (rogerbarreto)
marked this pull request as draft
April 23, 2025 06:37
…hub.com/rogerbarreto/semantic-kernel into issues/11628-functioninvoking-extension
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
April 23, 2025 06:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Roger Barreto (rogerbarreto)
added
needs discussion
Roger Barreto (rogerbarreto)
changed the title
Roger Barreto (rogerbarreto)
marked this pull request as ready for review
May 1, 2025 09:59
Roger Barreto (rogerbarreto)
added
PR: ready for review
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
May 1, 2025 12:28 — with
GitHub Actions
Failure
GitHub Actions
Failure
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
May 1, 2025 12:40 — with
GitHub Actions
Failure
GitHub Actions
Failure
This reverts commit f5847b9.
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
May 1, 2025 13:18 — with
GitHub Actions
Error
GitHub Actions
Error
…t/semantic-kernel into issues/11628-functioninvoking-extension
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
May 1, 2025 13:22 — with
GitHub Actions
Failure
GitHub Actions
Failure
SergeyMenshykh
approved these changes
May 1, 2025
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
May 2, 2025 17:10 — with
GitHub Actions
Failure
GitHub Actions
Failure
Roger Barreto (rogerbarreto)
had a problem deploying
to
integration
May 2, 2025 17:34 — with
GitHub Actions
Failure
GitHub Actions
Failure
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
May 2, 2025 17:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
May 2, 2025 18:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Dmytro Struk (dmytrostruk)
approved these changes
May 2, 2025
SergeyMenshykh
approved these changes
May 2, 2025
Roger Barreto (rogerbarreto)
temporarily deployed
to
integration
May 2, 2025 19:07 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Roger Barreto (rogerbarreto)
merged commit May 6, 2025
9381c8d
into
microsoft:feature-msextensions-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces changes recently merged to MEAI which allow flexibility and reusage from the higher level implementation perspective of Semantic Kernel.
FYI Stephen Toub (@stephentoub) Steve Sanderson (@SteveSandersonMS)