.Net Agents - Protect against null-reference for Assistant file-search result when streaming - #9742
Merged
Chris (crickman) merged 6 commits intoNov 19, 2024
Conversation
Chris (crickman)
added
bug
Mark Wallace (markwallace-microsoft)
added
the
kernel
Chris (crickman)
had a problem deploying
to
integration
November 18, 2024 21:22 — with 
GitHub Actions
Error
GitHub Actions
Error
Chris (crickman)
had a problem deploying
to
integration
November 18, 2024 21:24 — with
GitHub Actions
Failure
GitHub Actions
Failure
Chris (crickman)
requested review from
Ben Thomas (alliscode),
Estefanía Tenorio (esttenorio) and
Evan Mattson (moonbox3)
November 18, 2024 21:24
Chris (crickman)
temporarily deployed
to
integration
November 18, 2024 21:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Chris (crickman)
temporarily deployed
to
integration
November 18, 2024 23:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Chris (crickman)
temporarily deployed
to
integration
November 18, 2024 23:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Tao Chen (TaoChenOSU)
approved these changes
Nov 18, 2024
Chris (crickman)
removed
the
kernel
Estefanía Tenorio (esttenorio)
approved these changes
Nov 19, 2024
Chris (crickman)
deleted the
fix-assistant-streaming-filesearch-result
branch
November 19, 2024 03:29
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes: #9723
Must distinguish between file-search result and function-call result for assistant streaming without triggering
NullReferenceExceptionDescription
A file-search result provide any streaming result; rather, it results in an annotation on the assistant message. Still it must be distinguished from a function-call result.
Since
RunStepDetailsUpdate.FunctionNameproperty throws aNullReferenceExceptionwhen being evaluated, usingRunStepDetailsUpdate.FunctionResultproperty.Merged fix to Open AI SDK: openai/openai-dotnet#293
Contribution Checklist