This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Repository navigation
Added docs for dynamic data display name - #39
Merged
Jayarani garg (jayaranigarg) merged 2 commits intoApr 12, 2018
Merged
Conversation
Satya Madala (smadala)
approved these changes
Apr 10, 2018
Jayarani garg (jayaranigarg)
suggested changes
Apr 11, 2018
| `DynamicDataDisplayNameDeclaringType` should be used in cases where the dynamic data display name method exists in a class other than the test class | ||
|
|
||
| ```csharp | ||
| [DynamicData("ReusableTestDataMethod", DynamicDataDisplayName = "GetCustomDynamicDataDisplayName", DynamicDataDisplayNameDeclaringType = type(UnitTests))] |
Member
There was a problem hiding this comment.
Nit: typeOf(UnitTests)
Contributor
Author
There was a problem hiding this comment.
nice pick up 👍
Member
|
Brad Stoney (@bstoney) : Thanks a bunch for updating the documentation. Just a small typo. Please fix that and we should be all good to push both your Pull Requests in 😄 |
Jayarani garg (jayaranigarg)
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating DynamicData attribute docs to include changed in PR microsoft/testfx#373 as requested by Satya Madala (@smadala)