Repository navigation
license extension rename broke links #777
Description
Description
IMPORTANT: if the defect is reproduced only in a workflow from within the Visual Studio IDE then do not report the issue here - instead, please report it using Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com.
For a defect specific to the MSTest V2 test framework, describe the issue you've observed.
Side effect generated by #603. Also, taking in consideration that Github support LICENSE, why add the .txt?
I can open an MR, but in my opinion the problem is the file extension. Waiting for feedback.
Steps to reproduce
- Go to the License section on README.md and click on the MIT license link
Expected behavior
Open license content
Actual behavior
404
Activity
Fix LICENSE link in Readme.md
Haplois commentedon Feb 22, 2021
Thank you for the feedback. Let's remove the extension to comply with GitHub. I started a PR and abandoned it; if we're removing the extension, we need to update the build script and all other references to it.
Let me know if you like to do the PR, or I can do it as well.
3cpt commentedon Feb 22, 2021
I can do the PR, no problem.
Haplois commentedon Feb 23, 2021
Thank you, please @ me after you've created with the PR.
jnyrup commentedon Mar 19, 2021
Nuget seems to have problems linking to extension-less license files
Scenario: I use
Get-Package | Select-Object Id,LicenseUrlto list all licenses in my projects and for MSTest.TestAdapter it printsAs far as I understand the license displayed on show on https://www.nuget.org/packages/MSTest.TestAdapter/
is generated upon ingestion of the nuget package where it stores the license file from
<PackageLicenseFile>and generates a valid link to it.If this is changed to
the nuget pack will include
https://licenses.nuget.org/MITin the generated .nuspec file.Optionally use a combined approach, using
<PackageLicenseExpression>and embedding the license file, see https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csprojHaplois commentedon Mar 22, 2021
Hi,
It's not about extensionless license files. The issue you're having is because
licenseUrlis depracated. Even if we update this, you should stop using that and use the license expression included with the package itself.