Repository navigation
Porting Fixes for 1.2.1 - #396
Merged
Mayank Bansal (mayankbansal018) merged 7 commits intoApr 3, 2018
Merged
Conversation
* Base commit * Adding Unit Test * PR comments * Adding logs for diagnostics * Ignoring Test Temporarily * Removing ignore # Conflicts: # test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs
#372) * Today even if classInit wasnt called we used to call class cleanup. fixing that and adding a test to cover the scenario # Conflicts: # src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs
* COnverting portable pdbs to full for Symbol archiving * Fixing nuget package path * Test fix * Indent fix
* File version update * Moving to 15.6 * PR comments * More PR comments
…332) * Throwing exception only if it is of type TestPlatformFormatException * test * Fail discovery if any exception thrown in IDiscoveryContext.GetTestCaseFilter
# Conflicts: # src/Adapter/MSTest.CoreAdapter/Discovery/AssemblyEnumeratorWrapper.cs
Mayank Bansal (mayankbansal018)
requested review from
Jayarani garg (jayaranigarg) and
Satya Madala (smadala)
April 2, 2018 14:28
Satya Madala (smadala)
approved these changes
Apr 2, 2018
Satya Madala (smadala)
left a comment
Satya Madala (smadala)
left a comment
Contributor
There was a problem hiding this comment.
My commit is there.
Contributor
Author
|
dotnet bot (@dotnet-bot) test this please |
Siddhartha Pandey (acesiddhu)
approved these changes
Apr 3, 2018
Sarabjot Singh (singhsarab)
added a commit
to singhsarab/testfx
that referenced
this pull request
Apr 8, 2019
* Use direct conversions to/from JSON for TestCase and TestResult (without a local store for default properties) * Related to microsoft#396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: