Repository navigation
Description in TestCase - #538
Sarabjot Singh (singhsarab) merged 8 commits into
Conversation
…le in properties in the TestCase object.
| { | ||
| var attribute = GetCustomAttributes(attributeProvider, type, true); | ||
|
|
||
| if (attribute == null || attribute.Length != 1) |
There was a problem hiding this comment.
What if we have multiple workitem attributes? Do we want to silently ignore/not fill them in property bag?
There was a problem hiding this comment.
That's a valid concern. I just followed the same convention that was bein followed for Priority and Owner. https://github.com/Microsoft/testfx/blob/8384164a3187cd586134bfc230c337671300f68d/src/Adapter/MSTest.CoreAdapter/Helpers/ReflectHelper.cs#L599
There was a problem hiding this comment.
We cannot have multiple owner and priority attributes for a method as per framework restrictions. https://github.com/Microsoft/testfx/blob/master/src/TestFramework/MSTest.Core/Attributes/VSTestAttributes.cs#L188
But we can indeed have multiple workitem attributes. https://github.com/Microsoft/testfx/blob/master/src/TestFramework/MSTest.Core/Attributes/VSTestAttributes.cs#L297
There was a problem hiding this comment.
Good catch. Then, we'd ideally want to make workitem property an array of workitems.
2 participants
Make Description, CssIteration, WorkItem, CssProjectStructure available in properties in the TestCase object.
Fixes : #529