Thread ModelReaderWriterOptions through generated clients#11390
Draft
JonathanCrd wants to merge 2 commits into
Draft
Thread ModelReaderWriterOptions through generated clients#11390JonathanCrd wants to merge 2 commits into
JonathanCrd wants to merge 2 commits into
Conversation
Cache wire-format ModelReaderWriterOptions on generated clients and use them across request serialization, response deserialization, subclients, paging, and multipart content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d567d847-242a-47b9-af86-5e3eb1dd7031
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
Regenerate Sample and Spector outputs for threaded ModelReaderWriterOptions and mark derived ToBinaryContent helpers as new only when they hide a generated base helper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d567d847-242a-47b9-af86-5e3eb1dd7031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelReaderWriterOptionson each generated clientDependency
Draft pending the corresponding
System.ClientModelAPIs in Azure/azure-sdk-for-net#59083, includingClientPipelineOptions.ModelReaderWriterOptions, proxy resolution, andModelReaderWriterOptions(string format, ModelReaderWriterOptions options).The C# generated-project test jobs will continue to fail while CI restores the published
System.ClientModel1.14.0 package, which does not contain those APIs. The generator behavior was validated against a local package built from theproxy-rwbranch.Validation
Microsoft.TypeSpec.Generator.ClientModel.Testssuite before regenerationSystem.ClientModelpackage integration for generated Sample codepnpm formatnpm run cop