Skip to content

add spector test for jsonl - #6201

Merged
Chenjie Shi (tadelesh) merged 8 commits into
mainfrom
spector-jsonl
Mar 10, 2025
Merged

add spector test for jsonl#6201
Chenjie Shi (tadelesh) merged 8 commits into
mainfrom
spector-jsonl

Conversation

@tadelesh

@tadelesh Chenjie Shi (tadelesh) commented Feb 28, 2025

Copy link
Copy Markdown
Member

No description provided.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the lib:http-specs For issues/prs related to the @typespec/http-specs package label Feb 28, 2025
@tadelesh

Chenjie Shi (tadelesh) commented Feb 28, 2025

Copy link
Copy Markdown
Member Author

when regen doc for spector, i encountered this error. Timothee Guerin (@timotheeguerin) is it a problem in spector or in http lib?
image

@azure-sdk

Azure SDK Bot (azure-sdk) commented Feb 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

All changed packages have been documented.

  • ✅ @typespec/http-specs
  • ✅ @typespec/spector
Show changes

@typespec/http-specs - feature ✏️

Add tests for basic jsonl streaming.

@typespec/spector - feature ✏️

Support application/jsonl as binary.

@azure-sdk

Azure SDK Bot (azure-sdk) commented Feb 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@tadelesh
Chenjie Shi (tadelesh) marked this pull request as ready for review March 3, 2025 03:42
weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) approved these changes Mar 3, 2025
View reviewed changes

@weidongxu-microsoft Weidong Xu (weidongxu-microsoft) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the "pass" criteria for the test :-)

For the simple version, it would just be binary of such input/output to/from the API?

@tadelesh

Chenjie Shi (tadelesh) commented Mar 3, 2025

Copy link
Copy Markdown
Member Author

What would be the "pass" criteria for the test :-)

For the simple version, it would just be binary of such input/output to/from the API?

i think so. currently, we could only need to support send request or receive response with binary payload.

msyyc
Yuchao Yan (msyyc) approved these changes Mar 3, 2025
View reviewed changes
Comment thread packages/http-specs/specs/streaming/jsonl/mockapi.ts Resolved
@tadelesh

Chenjie Shi (tadelesh) commented Mar 4, 2025

Copy link
Copy Markdown
Member Author

Timothee Guerin (@timotheeguerin) could you help to review? i did not add full support of streaming for spector, just add make sure jsonl could be tested with binary send/receive way.

timotheeguerin
Timothee Guerin (timotheeguerin) approved these changes Mar 7, 2025
View reviewed changes

@timotheeguerin Timothee Guerin (timotheeguerin) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just don't thikn the new name is much better, but the content is good up to you what to do

Comment thread packages/http-specs/specs/streaming/jsonl/main.tsp Resolved
@tadelesh
Chenjie Shi (tadelesh) added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 8127b23 Mar 10, 2025
@tadelesh
Chenjie Shi (tadelesh) deleted the spector-jsonl branch March 10, 2025 03:22
@lmazuel Laurent Mazuel (lmazuel) mentioned this pull request Apr 4, 2025
Closed
Dmitrii Sedelnikov (dmnorc) pushed a commit to dmnorc/typespec that referenced this pull request Apr 9, 2025
@tadelesh @dmnorc
add spector test for jsonl (microsoft#6201)
28f019d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weidongxu-microsoft Weidong Xu (weidongxu-microsoft) weidongxu-microsoft approved these changes
@timotheeguerin Timothee Guerin (timotheeguerin) timotheeguerin approved these changes
@msyyc Yuchao Yan (msyyc) msyyc approved these changes
@bterlson Brian Terlson (bterlson) Awaiting requested review from bterlson
@markcowl Mark Cowlishaw (markcowl) Awaiting requested review from markcowl markcowl is a code owner
@allenjzhang Allen Zhang (allenjzhang) Awaiting requested review from allenjzhang
@witemple-msft Will Temple (witemple-msft) Awaiting requested review from witemple-msft
@chrisradek Christopher Radek (chrisradek) Awaiting requested review from chrisradek
@AlitzelMendez Alitzel Mendez (AlitzelMendez) Awaiting requested review from AlitzelMendez

Assignees

No one assigned

Labels

lib:http-specs For issues/prs related to the @typespec/http-specs package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tadelesh @azure-sdk @timotheeguerin @weidongxu-microsoft @msyyc