Avoid loading assemblies unnecessarily - #1256
Merged
Merged
Conversation
Loading the return type and parameters of a method forces the CLR to load the assemblies that declare those types. But unless the methods are invoked, we don't need to load them. This was showing up in a perf regression test.
Andrew Arnott (AArnott)
requested review from
Javier (javierdlg) and
murphymcquet-msft
August 20, 2025 20:44
Andrew Arnott (AArnott)
enabled auto-merge
August 20, 2025 20:45
murphymcquet-msft
approved these changes
Aug 20, 2025
This was referenced Jan 22, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading the return type and parameters of a method forces the CLR to load the assemblies that declare those types. But unless the methods are invoked, we don't need to load them. This was showing up in a perf regression test.