Fix perf regression in testing for RPC marshalable objects - #1330
Merged
Merged
Conversation
Andrew Arnott (AArnott)
requested review from
Sylvia Le (SylviaLe191),
Copilot and
Matteo Prosperi (matteo-prosperi)
October 21, 2025 02:05
Andrew Arnott (AArnott)
enabled auto-merge
October 21, 2025 02:05
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a performance regression in RPC marshalable object testing by restoring early exit behavior when a type is not an interface and introducing caching for redundant attribute checks. The changes optimize the type checking logic to reduce unnecessary attribute lookups.
Key Changes:
- Modified
TryGetMarshalOptionsForTypeHelperto returnbool?instead ofbool, enabling distinction between "definitely not marshalable" (false) and "unknown, needs more checking" (null) - Added caching for
RpcMarshalableAttributelookups via newRpcMarshalableAttributeCachedictionary - Replaced direct
GetCustomAttributecalls with cachedTryGetRpcMarshalableAttributemethod
| } | ||
|
|
||
| return false; | ||
| // Unknown. Caller may want to do more work. |
There was a problem hiding this comment.
[nitpick] While more descriptive than the previous comment, this could be clearer. Consider: 'Return null to indicate the interface type requires further validation by the caller.'
Suggested change
| // Unknown. Caller may want to do more work. | |
| // Return null to indicate the interface type requires further validation by the caller. |
Matteo Prosperi (matteo-prosperi)
approved these changes
Oct 21, 2025
This was referenced Jan 22, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some recent refactoring inadvertently caused RPC marshalable object testing to not break out early when the type is not an interface.
In this change, I correct that mistake. I also cache redundant attribute checks for interface types.
As reported in devdiv-2575202