This repository was archived by the owner on May 20, 2026. It is now read-only.
Rename skillContentRead telemetry properties to use 'skill' prefix#5082
Closed
AbhitejJohn wants to merge 1 commit into
Closed
Rename skillContentRead telemetry properties to use 'skill' prefix#5082AbhitejJohn wants to merge 1 commit into
AbhitejJohn wants to merge 1 commit into
Conversation
AbhitejJohn
force-pushed
the
aajohn/skill-telemetry-prefix
branch
from
701e960 to
456449c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames telemetry properties emitted by the ReadFileTool’s skillContentRead event so that all related fields are consistently prefixed with skill, reducing ambiguity for analytics consumers.
Changes:
- Renamed
sendGHTelemetryEvent('skillContentRead')properties toskillExtensionIdHash,skillExtensionVersion, andskillContentHash. - Renamed plaintext properties used by enhanced GH + internal MSFT telemetry to
skillExtensionId,skillExtensionVersion, andskillContentHash. - Updated unit test assertions (and one test title) to match the renamed properties.
Show a summary per file
| File | Description |
|---|---|
| src/extension/tools/node/readFileTool.tsx | Updates skillContentRead telemetry payload property names to use the skill* prefix consistently. |
| src/extension/tools/node/test/readFile.spec.tsx | Adjusts telemetry assertions to validate the new property names for GH/enhanced/internal events. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
pwang347
approved these changes
Apr 21, 2026
dmitrivMS
approved these changes
Apr 21, 2026
auto-merge was automatically disabled
April 22, 2026 00:07
Pull request was converted to draft
auto-merge was automatically disabled
April 22, 2026 00:17
Pull request was converted to draft
Contributor
Author
|
Abandoning in favor of microsoft/vscode#311945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames telemetry properties in the
skillContentReadevent to add askillprefix, aligning property names with the event name to reduce ambiguity in the collected data. This was suggested by folks on the data team.Property Renames
GH telemetry event (
sendGHTelemetryEvent)extensionIdHashskillExtensionIdHashextensionVersionskillExtensionVersioncontentHashskillContentHashEnhanced GH + Internal MSFT events (plaintext props)
extensionIdskillExtensionIdextensionVersionskillExtensionVersioncontentHashskillContentHashProperties that already had the
skillprefix (skillName,skillPath,skillStorage,skillNameHash) are unchanged.Testing
readFile.spec.tsxto match the new property names