This repository was archived by the owner on May 20, 2026. It is now read-only.
feat: add languageDiagnosticsService for nes/inline completion provider#5119
Open
SLdragon wants to merge 1 commit into
Open
feat: add languageDiagnosticsService for nes/inline completion provider#5119SLdragon wants to merge 1 commit into
SLdragon wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional languageDiagnosticsService hook to the chat-lib entrypoints so callers can provide diagnostics that can be used to enrich prompts (e.g., with active-file lint/error context).
Changes:
- Extended
INESProviderOptionswith optionallanguageDiagnosticsService. - Extended
IInlineCompletionsProviderOptionswith optionallanguageDiagnosticsService. - Wired both service builders to register the provided diagnostics service, falling back to
TestLanguageDiagnosticsServicewhen not supplied.
| readonly configOverrides?: Map<ConfigKeyType, unknown>; | ||
| /** | ||
| * Diagnostics provider used to enrich the NES prompt with the active file's | ||
| * lint/error context. When omitted, falls back to a no-op {@link TestLanguageDiagnosticsService}. |
SLdragon
changed the title
Member
|
Thanks for the contribution! This repository has been archived because the project has moved into the main VS Code repository. Could you please reopen/recreate this PR against: We’ll continue reviewing contributions there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional languageDiagnosticsService to INESProviderOptions and IInlineCompletionsProviderOptions, allowing external embedders of @vscode/chat-lib to provide their own diagnostics source for NES and inline completion requests.