Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Import syntax matters #36

Open
Open

Description

@TylerLeonhardt

From my testing, the import syntax used had to be in the form:

import * as nls from 'vscode-nls';

and the following wasn't picked up:

import { loadMessageBundle } from 'vscode-nls';

Activity

  1. added
    bugIssue identified by VS Code Team member as probable bug
    on May 4, 2022
  2. added this to the Backlog milestone on May 4, 2022
  3. dbaeumer commented on May 5, 2022

    @dbaeumer
    Member

    That is correct and for simplicity. Major reason is that we would need to have fully correct code to make sure that we have all symbol bindings in the TS compiler to make the right decisions. Someone could for example write

    import { loadMessageBundle  as myFunctionName } from 'vscode-nls';

    We also don't support things like

    const myFunctionName = loadMessageBundle;

    for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions