[Dmitriy Vasyura (dmitrivMS)]

Summary

Forward the remote resolver's environment to server-owned Agent Host launches so shell tools can inherit Codespaces-provisioned credentials such as GITHUB_TOKEN.

Normal remote terminals and the extension host already merge extensionHostEnv. The remote Agent Host connection did not forward it, leaving its child processes without variables supplied through that route. This affects both editor chat and the Agents window; changing the default harness can expose the gap but is not required to hit it.

Changes

• Resolve the current authority environment for each IPC connection, preserving resolver precedence over debug-launch overrides.
• Carry and validate optional launch overrides through the VS Code-only connect IPC call, outside AHP messages and logs.
• Apply overrides before the default server-owned lazy launch; preserve null removals, empty strings, launcher-owned values, and environment snapshots for crash recovery.
• Leave explicitly configured/external upstreams unchanged.
• Add coverage for both window types, reconnect-time resolution, disposal and error handling, log privacy, launch precedence, and retained restart overrides.

[Copilot]

🟡 Changes recommended

Concurrent connections can discard the later environment snapshot and launch with stale credentials.

1 open finding

• Shared endpoint promise drops refreshed connection options · New

What changed in this PR

Forwards remote resolver environments to server-owned Agent Host launches, preserving Codespaces credentials across launches and crash recovery.

Changes:

• Adds validated IPC launch environment options.
• Applies resolver overrides with appropriate precedence and null handling.
• Adds coverage for forwarding, failures, privacy, and restarts.

File	Description
src/​vs/​workbench/​services/​agentHost/​browser/​editorRemoteAgentHostServiceClient.ts	Resolves and forwards remote environments.
src/​vs/​workbench/​services/​agentHost/​test/​browser/​editorRemoteAgentHostServiceClient.test.ts	Tests both window types and reconnections.
src/​vs/​platform/​agentHost/​common/​agentService.ts	Defines IPC connection options.
src/​vs/​platform/​agentHost/​browser/​agentHostIpcChannelTransport.ts	Sends launch options during connection.
src/​vs/​platform/​agentHost/​test/​browser/​agentHostIpcChannelTransport.test.ts	Tests resolution, disposal, errors, and privacy.
src/​vs/​server/​node/​agentHostChannel.ts	Validates and relays launch options.
src/​vs/​server/​test/​node/​agentHostChannel.test.ts	Tests validation and forwarding behavior.
src/​vs/​server/​node/​serverServices.ts	Applies overrides to lazy server launches.
src/​vs/​platform/​agentHost/​node/​nodeAgentHostStarter.ts	Retains and merges environment snapshots.
src/​vs/​platform/​agentHost/​test/​node/​nodeAgentHostStarter.test.ts	Tests precedence, removals, and restart retention.

🧠 Review effort: Balanced

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

Credential propagation affects shared process launch and recovery behavior, while live Codespaces validation remains pending.

0 open findings

1 resolved since last review

• Shared endpoint promise drops refreshed connection options

🧠 Review effort: Balanced

[Connor Peet (connor4312)]

Reviewed the complete merge-base diff and the environment flow through resolver, renderer transport, server channel, and process launch/recovery. One P2 finding: the new starter test introduces process-global configuration registration that breaks other unit suites. This explains the two Electron-Unit failures on Linux, macOS, and Windows; they are not unrelated CI failures.

The production forwarding approach looks reasonable, and the relevant IPC, starter, channel, and client regressions pass in CI. No P1 issues found. Please address the test isolation issue before approval.

[Dmitriy Vasyura (dmitrivMS)]

Addressed both additional regression findings in cb16f29:

• Reconnect recovery: a failed remote-authority environment lookup now logs a credential-free warning and continues into the existing buffered IPC connection without launch overrides. It does not clear the server's saved environment, and subsequent connections retry discovery. This avoids spending the Agent Host reconnect budget on transient resolver failures before reaching IPC.
• Windows precedence/deletion: debug-launch and resolver environments remain separate across IPC and are merged on the server using the remote OS's casing rules. The final merge includes the inherited and login-shell environments, with launcher-owned values applied last and undefined deletion markers retained for the IPC child-process merge.

New tests cover the buffered connection and later resolver recovery, separate-layer forwarding/validation, native host casing, and real Windows child-process replacement, empty-string, and token-removal behavior. No real credentials are read or printed by those probes.

Fixed issues

[Connor Peet (connor4312)]

Reviewed the complete diff and relevant remote source context for security and correctness. No substantiated P1 or P2 findings remain. The prior concurrent-environment and configuration-registration issues are addressed in the current head; cross-platform Electron-Unit and compile/hygiene checks pass.

_{Written by Connor's agent running GPT-6.1 Sol}