Repository navigation
Optimize role principal data in schedule-instance exports - #1600
Open
Naga Praneeth Chukka (praneeth-0000) wants to merge 3 commits into
Open
Naga Praneeth Chukka (praneeth-0000) wants to merge 3 commits into
Naga Praneeth Chukka (praneeth-0000) wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed batch-member lookups are cached as completed, preventing enrichment retries on later pages.
1 open finding
What changed in this PR
Reduces schedule-instance export payloads while retaining principal details needed for role processing.
Changes:
- Requests ID-only principals and enriches them through a shared per-export cache.
- Trims both schedule-instance models to minimal principal fields.
- Adds regression coverage for enrichment, caching, and lookup failures.
| File | Description |
|---|---|
| src/powershell/private/export/Resolve-ZtRoleAssignmentPrincipal.ps1 | Adds principal resolution and caching. |
| src/powershell/private/export/Export-ZtGraphEntity.ps1 | Enriches principals before exporting each page. |
| src/powershell/assets/export-tenant.config.psd1 | Enables ID-only expansion and enrichment. |
| src/powershell/assets/export-model/RoleEligibilityScheduleInstance-model.json | Removes unused principal fields. |
| src/powershell/assets/export-model/RoleAssignmentScheduleInstance-model.json | Removes unused principal fields. |
| code-tests/commands/Export-ZtGraphEntity.Tests.ps1 | Covers principal enrichment and cache behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Naga Praneeth Chukka (praneeth-0000)
requested review from
Aleksandar Nikolić (alexandair) and
Anton Staykov (astaykov)
October 16, 2026 11:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Overall result