Repository navigation
Angular 21: standalone components, Vitest and angular19 CI - #1449
Merged
Merged
Conversation
PR CI checks out the frontend (and sibling plugins) at the branch the PR targets instead of always stable. Corepack is enabled before every yarn install, since the frontend's angular19 branch pins yarn@4; the Docker build uses yarn for the frontend build as well. Dead WDIO config copies are dropped (the frontend no longer has WDIO). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also removes the dead SettingsRemoveSiteModalComponent (legacy mdbModal, not declared or referenced anywhere), which cannot compile standalone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The unresolved dialog dependency-injection issue and cross-repository CI integration require correction and runtime validation before human approval.
1 open issue
What changed in this PR
Updates the workflow plugin for the frontend’s Angular 21 migration.
Changes:
- Converts components to standalone imports and simplifies the feature module.
- Migrates add-site tests to Vitest and removes the unused remove-site modal.
- Adds Angular unit-test CI jobs and updates frontend checkout and Yarn setup.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/workflow-pn/workflow-pn.module.ts | Removes declarations and shared template imports. |
| eform-client/src/app/plugins/modules/workflow-pn/layouts/workflow-pn-layout.component.ts | Imports standalone router outlet. |
| eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-cases-page/workflow-cases-page.component.ts | Adds standalone template dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-case-edit/workflow-case-edit.component.ts | Adds standalone editor dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-case-delete/workflow-case-delete.component.ts | Adds standalone dialog dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/workflow-settings/workflow-settings.component.ts | Adds standalone settings dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/workflow-folders-modal/workflow-folders-modal.component.ts | Adds standalone folder-picker dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.ts | Deletes unused component. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.spec.ts | Deletes obsolete test. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.scss | Removes unused stylesheet. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-remove-site-modal/settings-remove-site-modal.component.html | Deletes legacy modal template. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-add-site-modal/settings-add-site-modal.component.ts | Adds standalone add-site dependencies. |
| eform-client/src/app/plugins/modules/workflow-pn/components/settings/settings-add-site-modal/settings-add-site-modal.component.spec.ts | Migrates to Vitest and checks site filtering. |
| eform-client/src/app/plugins/modules/workflow-pn/components/index.ts | Removes commented-out export. |
| Dockerfile | Enables Corepack and builds with Yarn. |
| .github/workflows/dotnet-core-pr.yml | Adds unit tests, target-branch checkout, and Corepack. |
| .github/workflows/dotnet-core-master.yml | Adds unit tests and Corepack; removes obsolete copies. |
Review effort: Balanced
…ervices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Angular 21 upgrade. The frontend's
angular19branch is now on Angular 21 with standalone components and Vitest (microting/eform-angular-frontend#8155).yarn install, because the frontend'sangular19pins Yarn 4. The Dockerfile builds the frontend with yarn. Dead WDIO copy steps are removed.declarationsare removed.angular-unit-testCI job runs it withng test. The unusedSettingsRemoveSiteModalComponentis removed: it was referenced only in comments, and its legacymdbModaltemplate can't compile as standalone.Verified locally with
ng buildagainst frontendangular19, together with the other migrated plugins. Code reviewed. Not yet clicked through in a browser.🤖 Generated with Claude Code