Skip to content

upstream sync: 1 commit(s) at 0a5cd04ae95e #70

Closed as not planned
Closed as not planned

Description

@mikeroysoft-agent

Automatic sync of ROCm/rocm-cli main into main: 1 new upstream commit(s), tip 0a5cd04ae95e6422df6bb4ba4b95d3216bf637e5.

The candidate branch (this ticket's agent/ branch, your worktree) starts from main and contains the merge of the tip; the dispatcher's gate on it FAILED.

Gate report (detached candidate)

Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in _run_code
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/main.py", line 3, in
raise SystemExit(main())
^^^^^^
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/cli.py", line 52, in main
return import_module(f"factory.{module}").dictfunc
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/gate.py", line 259, in main
return execute(args, execution)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/gate.py", line 336, in execute
passed, output = fn()
^^^^
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/gate.py", line 306, in
configured = [(check.name, (lambda c=check: run(c.run))) for check in listed]
^^^^^^^^^^
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/gate.py", line 84, in run
proc = timed(cmd)
^^^^^^^^^^
File "/home/mike/.local/share/uv/tools/factory/lib/python3.12/site-packages/factory/gate.py", line 58, in timed
out, _ = proc.communicate(timeout=CHECK_TIMEOUT)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mike/.local/share/uv/python/cpython-3.12.14-linux-x86_64-gnu/lib/python3.12/subprocess.py", line 1209, in communicate
stdout, stderr = self._communicate(input, endtime, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mike/.local/share/uv/python/cpython-3.12.14-linux-x86_64-gnu/lib/python3.12/subprocess.py", line 2153, in _communicate
stdout = self._translate_newlines(stdout,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mike/.local/share/uv/python/cpython-3.12.14-linux-x86_64-gnu/lib/python3.12/subprocess.py", line 1086, in _translate_newlines
data = data.decode(encoding, errors)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 218823: invalid start byte

Exit gate: HEAD contains upstream tip 0a5cd04ae95e6422df6bb4ba4b95d3216bf637e5 (merge it; never squash or rebase it away) and the gate passes. The dispatcher rejects a passing gate whose HEAD does not contain the tip. Never push main; the merge stage lands the reviewed PR.

Activity

  1. added and removed
    ready-for-agentFully specified and ready for an AFK agent
    on Oct 19, 2026
  2. removed their assignment
    on Oct 19, 2026
  3. mikeroysoft-agent commented on Oct 19, 2026

    @mikeroysoft-agent
    CollaboratorAuthor

    Factory dispatcher escalating: PR #71: CI failed (clippy, prek (lint / hygiene)); factory-approved label removed.

    Escalation packet: /home/mike/.local/share/district/roots/rocm-cli/.factory/escalations/70.md

    Worker handoff notes:

    Handoff #70 — upstream sync at 0a5cd04

    State

    • HEAD contains upstream tip 0a5cd04ae95e via merge 8cc95a9f (unchanged, not squashed/rebased).
    • factory gate --report .factory/gate-report-70.md: PASS (conflict-markers, clippy, tests, smoke, leak-scan).

    Cause of the failed gate

    Not the upstream commit (README + crates/rocm-dash-tui/src/agent/clients.rs only).
    crates/rocm-core/src/uv.rs::extract_archive ran system tar with inherited stderr.
    The uv archive property tests (archive_props, fixed seed) feed member names like \xff\xfe/..;
    GNU tar echoes them raw ("Removing leading ... from member names") regardless of locale, past
    libtest capture, into cargo test output. factory's gate.timed decodes check output with
    text=True (strict UTF-8) and crashed with UnicodeDecodeError.

    Change (commit f3302ea)

    • extract_archive now uses .output() and puts tar's stderr (lossy UTF-8) in the error,
      matching therock's extract_tarball (run_command) pattern.
    • Regression test uv::tests::a_failed_extraction_reports_what_tar_said: failed before (error
      lacked tar's diagnosis, which leaked to stderr), passes after. cargo test -p rocm-core --lib uv::
      output now has 0 bytes of 0xff (was 16).

    Unverified

    • Windows: the test accepts tar.exe: (bsdtar prefix) by assumption; not run on Windows.
    • Behavior change: tar warnings on a successful uv extraction are no longer shown to the user.

    Next

    • This is a fork-local change to an upstream-tracked file; consider sending it upstream to avoid divergence.
    • factory itself is fragile here: factory/gate.py::timed should decode with errors="replace"
      so any non-UTF-8 check output fails/reports instead of crashing the gate. Not changed (separate repo).
  4. mikeroysoft-agent commented on Oct 19, 2026

    @mikeroysoft-agent
    CollaboratorAuthor

    Factory dispatcher escalating: PR #71: CI failed (Commit signatures + sign-off); factory-approved label removed.

    Escalation packet: /home/mike/.local/share/district/roots/rocm-cli/.factory/escalations/70.md

    Worker handoff notes:

    Handoff #70 — upstream sync at 0a5cd04

    State

    • HEAD contains upstream tip 0a5cd04ae95e via merge 8cc95a9f (unchanged, not squashed/rebased).
    • factory gate --report .factory/gate-report-70.md: PASS (conflict-markers, clippy, tests, smoke, leak-scan).

    Cause of the failed gate

    Not the upstream commit (README + crates/rocm-dash-tui/src/agent/clients.rs only).
    crates/rocm-core/src/uv.rs::extract_archive ran system tar with inherited stderr.
    The uv archive property tests (archive_props, fixed seed) feed member names like \xff\xfe/..;
    GNU tar echoes them raw ("Removing leading ... from member names") regardless of locale, past
    libtest capture, into cargo test output. factory's gate.timed decodes check output with
    text=True (strict UTF-8) and crashed with UnicodeDecodeError.

    Change (commit f3302ea)

    • extract_archive now uses .output() and puts tar's stderr (lossy UTF-8) in the error,
      matching therock's extract_tarball (run_command) pattern.
    • Regression test uv::tests::a_failed_extraction_reports_what_tar_said: failed before (error
      lacked tar's diagnosis, which leaked to stderr), passes after. cargo test -p rocm-core --lib uv::
      output now has 0 bytes of 0xff (was 16).

    Unverified

    • Windows: the test accepts tar.exe: (bsdtar prefix) by assumption; not run on Windows.
    • Behavior change: tar warnings on a successful uv extraction are no longer shown to the user.

    Next

    • This is a fork-local change to an upstream-tracked file; consider sending it upstream to avoid divergence.
    • factory itself is fragile here: factory/gate.py::timed should decode with errors="replace"
      so any non-UTF-8 check output fails/reports instead of crashing the gate. Not changed (separate repo).
  5. mikeroysoft-agent commented on Oct 19, 2026

    @mikeroysoft-agent
    CollaboratorAuthor

    Factory handoff request 70/2: a human decision is needed on #70.

    No decision owner could be determined (unassigned); a maintainer should claim it.

    Question
    How should #70 proceed? It escalated with: PR #71: CI failed (Commit signatures + sign-off); factory-approved label removed. Automatic recovery stopped because the manager's 1 allowed round(s) are exhausted.

    Evidence (bounded links; worker logs and the escalation packet stay on the runner)

    Proposed next step
    Read the evidence, then amend the ticket and relabel ready-for-agent for another attempt, fix the branch by hand, request changes on the PR, or close it. Replying here is context for humans; nothing here retries, approves or merges.

    Routing

    • decision_owner: absent — ticket body has no **Decision owner** section
    • initiative: skipped — initiative owner only routes requirements, not ci
    • configuration: absent — no [collaboration] section in .factory.toml; legacy behaviour unchanged
      To claim or reassign this decision, set a **Decision owner** section (a GitHub login) in the issue body; the next pass reflects it and never overwrites it.
  6. added
    ready-for-agentFully specified and ready for an AFK agent
    and removed on Oct 20, 2026
  7. added and removed
    ready-for-agentFully specified and ready for an AFK agent
    on Oct 20, 2026
  8. mikeroysoft-agent commented on Oct 20, 2026

    @mikeroysoft-agent
    CollaboratorAuthor

    Factory dispatcher escalating: PR #71: 7 unresolved feedback item(s) on head 378bb40.

    Escalation packet: /home/mike/.local/share/district/roots/rocm-cli/.factory/escalations/70.md

    Worker handoff notes:

    Handoff #70 — upstream sync at 0a5cd04

    State

    • HEAD contains upstream tip 0a5cd04ae95e via merge 8cc95a9f (unchanged, not squashed/rebased).
    • factory gate --report .factory/gate-report-70.md: PASS (conflict-markers, clippy, tests, smoke, leak-scan).

    Cause of the failed gate

    Not the upstream commit (README + crates/rocm-dash-tui/src/agent/clients.rs only).
    crates/rocm-core/src/uv.rs::extract_archive ran system tar with inherited stderr.
    The uv archive property tests (archive_props, fixed seed) feed member names like \xff\xfe/..;
    GNU tar echoes them raw ("Removing leading ... from member names") regardless of locale, past
    libtest capture, into cargo test output. factory's gate.timed decodes check output with
    text=True (strict UTF-8) and crashed with UnicodeDecodeError.

    Change (commit f3302ea)

    • extract_archive now uses .output() and puts tar's stderr (lossy UTF-8) in the error,
      matching therock's extract_tarball (run_command) pattern.
    • Regression test uv::tests::a_failed_extraction_reports_what_tar_said: failed before (error
      lacked tar's diagnosis, which leaked to stderr), passes after. cargo test -p rocm-core --lib uv::
      output now has 0 bytes of 0xff (was 16).

    Unverified

    • Windows: the test accepts tar.exe: (bsdtar prefix) by assumption; not run on Windows.
    • Behavior change: tar warnings on a successful uv extraction are no longer shown to the user.

    Next

    • This is a fork-local change to an upstream-tracked file; consider sending it upstream to avoid divergence.
    • factory itself is fragile here: factory/gate.py::timed should decode with errors="replace"
      so any non-UTF-8 check output fails/reports instead of crashing the gate. Not changed (separate repo).
  9. mikeroysoft-agent commented on Oct 20, 2026

    @mikeroysoft-agent
    CollaboratorAuthor

    Factory handoff request 70/3: a human decision is needed on #70.

    No decision owner could be determined (unassigned); a maintainer should claim it.

    Question
    How should #70 proceed? It escalated with: PR #71: 7 unresolved feedback item(s) on head 378bb40. Automatic recovery stopped because the manager's 1 allowed round(s) are exhausted.

    Evidence (bounded links; worker logs and the escalation packet stay on the runner)

    Proposed next step
    Read the evidence, then amend the ticket and relabel ready-for-agent for another attempt, fix the branch by hand, request changes on the PR, or close it. Replying here is context for humans; nothing here retries, approves or merges.

    Routing

    • decision_owner: absent — ticket body has no **Decision owner** section
    • initiative: skipped — initiative owner only routes requirements, not implementation
    • configuration: absent — no [collaboration] section in .factory.toml; legacy behaviour unchanged
      To claim or reassign this decision, set a **Decision owner** section (a GitHub login) in the issue body; the next pass reflects it and never overwrites it.
  10. mikeroySoft commented on Oct 23, 2026

    @mikeroySoft
    Owner

    Closing this stale upstream sync: an open sync issue parks every newer sync, and it is holding back 16 upstream commits, including ROCm/rocm-cli ROCm#712 (the reclaim-gpu self-test fix failing CI on ubuntu-26.04). The factory will stage a fresh sync from current upstream. The tar-stderr fix (f3302ea) also lives in #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions