Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tick the box to add this pull request to the merge queue (same as
|
yhmo
commented
Sep 23, 2026
yhmo
commented
Sep 23, 2026
yhmo
force-pushed
the
mm
branch
2 times, most recently
from
September 24, 2026 04:05
144e214 to
58a64b5
Compare
yhmo
commented
Sep 24, 2026
yhmo
commented
Sep 24, 2026
- getPartitionStats: fall back to 0L for numOfEntities when row_count is absent, matching getCollectionStats - delete: raise INVALID_PARAMS instead of NPE when neither filter nor ids is provided; dropCollectionField requires exactly one of fieldName/fieldId - compact: send collection_name on the wire (ManualCompactionRequest), matching pymilvus - getLoadStateV2: return LoadStateNotExist when the collection does not exist; the legacy Boolean getLoadState keeps throwing - deprecate addCollectionFunction and dropCollectionFunction; use addFunctionField and dropFunctionField instead (pymilvus parity) - docs: add V2 examples for index, alias, partition, database and analyzer APIs - examples: demonstrate alterCollectionField on a newly added field - pymilvus parity: allow null config in createResourceGroup and empty map in updateResourceGroups, guard null compaction IDs in getCompactionState/getCompactionPlans, populate GrantInfo.roleName in describeRole, add functionName member to alterCollectionFunction - add listCompactionTasks API (closes the last missing pymilvus interface) and bump milvus-proto submodule to expose collection_name in GetCompactionPlansRequest - ci: compile the examples module (install sdk-bulkwriter first) so new examples are verified Signed-off-by: yhmo <yihua.mo@zilliz.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the low-risk, high-value gaps found in the Java-vs-PyMilvus parity audit, plus docs/examples.
Hardening fixes
NoSuchElementExceptionwhen the server omitsrow_count;numOfEntitiesfalls back to0L(matchinggetCollectionStats).INVALID_PARAMSerror instead of an NPE when neitherfilternoridsis provided; drop field now requires exactly one offieldName/fieldId.collection_nameon the wire (ManualCompactionRequest), matching pymilvus.LoadStateNotExistinstead of throwing when the collection does not exist; the legacy BooleangetLoadStatekeeps throwing sincefalsewould mislead as "not loaded". For a non-existent partition the proxy returns a partition-not-found error status, sogetLoadStateV2still throws there, matching pymilvus.Deprecations (pymilvus parity)
addCollectionFunction/dropCollectionFunction(and their request classes) are now@Deprecated, replaced byaddFunctionField/dropFunctionField.Missing / partial API parity
MilvusClientV2interface); bumps themilvus-protosubmodule to exposecollection_nameonGetCompactionPlansRequest.GrantInfo.roleNameis now populated per grant.functionNamemember (falls back toFunction.getName()).INVALID_PARAMSerror.nullconfig (server default); updateResourceGroups: accepts an empty config map.Docs / examples
AddFieldExamplenow demonstratesalterCollectionField(e.g. changingmax_length).Tests:
mvn -pl sdk-core -o -Pintegration test(2528 unit + integration tests) passes.