Preparations for release of preview version 3 - #950
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several project dependencies, increments the version to 2.0.0-preview.3, and renames template-related methods from 'ApplyTemplate' to 'FillTemplate'. It also removes the Newtonsoft.Json dependency from the test projects, replacing it with System.Text.Json or manual object construction. Feedback is provided regarding the migration to System.Text.Json in 'TestIssue370', where deserializing to a dictionary results in 'JsonElement' values instead of primitives. This change necessitates manual parsing in assertions and reduces the test's effectiveness; it is recommended to define the test data directly to preserve type fidelity.
…llTemplateAsync for keeping consistency with the OpenXmlTemplater methods' names Previous method signatures were marked with ObsoleteAttribute to prevent current preview version builds to break, and will be subsequently removed.
6049182 to
2571731
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 2.0.0-preview.3, renames template-related methods from ApplyTemplate to FillTemplate (marking the old ones as obsolete), and significantly refactors the documentation and benchmarks. Feedback focuses on several critical compilation errors caused by the removal of required using statements for source generators and compiler services. Additionally, there is a missing dependency for ToListAsync() in tests, a logic error in a test assertion regarding decimal precision, and a minor formatting issue.
…nXml.Tests test project, also deleting pointless json serialization from some tests
…ead of a 1 million rows one This reduces the benchmarking duration from 6 hours to 25 minutes.
Removed the suprefluous README-NuGet.md file from the solution, revised the actual README.md file included in the nuget package and updated minor details in the README-V2.md and V2-Upgrade-Notes.md files.
5168483 to
1040113
Compare
* Renaming MappingTemplater's ApplyTemplateAsync method overloads to FillTemplateAsync for keeping consistency with the OpenXmlTemplater methods' names Previous method signatures were marked with ObsoleteAttribute to prevent current preview version builds to break, and will be subsequently removed. * Updating packages and removing Newtonsoft.Json from the MiniExcel.OpenXml.Tests test project, also deleting pointless json serialization from some tests * Refactoring benchmarks to be based off a 100,000 rows Excel file instead of a 1 million rows one This reduces the benchmarking duration from 6 hours to 25 minutes. * Fixing benchmark.yml workflow file and bumping project version * Updating readme files Removed the suprefluous README-NuGet.md file from the solution, revised the actual README.md file included in the nuget package and updated minor details in the README-V2.md and V2-Upgrade-Notes.md files.
1 participant
MappingTemplater'sApplyTemplateAsyncmethod overloads toFillTemplateAsyncfor keeping consistency with theOpenXmlTemplaterrespective methods' namesMiniExcel.Ope nXml.Teststest project