Skip to content

Fix Blazor converter stuck on Loading - #126

Merged
shps951023 merged 1 commit into
mainfrom
fix/blazor-root-component
Sep 4, 2026
Merged

Fix Blazor converter stuck on Loading#126
shps951023 merged 1 commit into
mainfrom
fix/blazor-root-component

Conversation

@shps951023

@shps951023 shps951023 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • restore the standalone Blazor WebAssembly root component registration
  • mount App into #app so the converter replaces the static Loading placeholder

Validation

  • dotnet publish MiniPdf.Web/MiniPdf.Web.Client/MiniPdf.Web.Client.csproj -c Release
  • verified the published app renders the full converter UI in a browser

Summary by CodeRabbit

  • Bug Fixes
    • The web application now correctly loads and displays its main application component, improving startup and rendering reliability.

Restore the App root component registration so the WebAssembly converter mounts into #app instead of remaining on the static Loading screen.
Copilot AI lite review requested due to automatic review settings September 4, 2026 06:03
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 1234219d-fb76-493b-a421-dc38a070b198

📥 Commits

Reviewing files that changed from the base of the PR and between 2c60353 and 34a3a4a.

📒 Files selected for processing (1)
  • MiniPdf.Web/MiniPdf.Web.Client/Program.cs

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Blazor WebAssembly client now registers the App root component at the #app DOM selector.

Changes

Client root registration

Layer / File(s) Summary
Register the App root component
MiniPdf.Web/MiniPdf.Web.Client/Program.cs
Adds builder.RootComponents.Add<App>("#app") to register the root component.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 34a3a

The client now mounts the converter application into the existing #app placeholder, replacing the loading screen as intended. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the Blazor converter that remains stuck on the "Loading" screen.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/blazor-root-component

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, correctly targets the existing <div id="app"> host element, and addresses the reported “stuck on Loading” behavior without introducing additional risk.

Pull request overview

This PR fixes the Blazor WebAssembly converter UI being stuck on the static “Loading…” placeholder by restoring the WASM root component mounting so the app actually renders into the host page.

Changes:

  • Register the App root component in the WASM client startup.
  • Mount App into the #app element (matching wwwroot/index.html) so the placeholder content is replaced at runtime.
File summaries
File Description
MiniPdf.Web/MiniPdf.Web.Client/Program.cs Restores root component registration so the WASM app mounts into #app and renders the converter UI.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@shps951023
shps951023 merged commit 74fc8f5 into main Sep 4, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants