Skip to content

Use tracked fixtures in Java release tests - #128

Merged
shps951023 merged 1 commit into
mainfrom
fix/java-release-tracked-fixtures
Sep 4, 2026
Merged

Use tracked fixtures in Java release tests#128
shps951023 merged 1 commit into
mainfrom
fix/java-release-tracked-fixtures

Conversation

@shps951023

Copy link
Copy Markdown
Member

Summary

  • use Git-tracked shared XLSX and DOCX fixtures in Java library smoke tests
  • use the same tracked fixtures in Java CLI tests
  • make Maven release builds reproducible from a clean clone

Validation

  • focused tracked-fixture test: 3 passed
  • Java Maven reactor: 33 tests passed
  • git diff --check passed

Copilot AI lite review requested due to automatic review settings September 4, 2026 07:39
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e46f5a84-6ddc-4152-9e06-7e522c5d7ebf

📥 Commits

Reviewing files that changed from the base of the PR and between e62472e and c61a74a.

📒 Files selected for processing (2)
  • minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java
  • minipdf-java/minipdf/src/test/java/io/github/minisoftware/minipdf/ClassicFixtureSmokeTest.java

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The functional changes align with the PR goals and the only remaining findings are minor indentation issues in updated test lines.

Pull request overview

This PR updates the Java library and CLI smoke tests to use Git-tracked XLSX/DOCX fixtures under tests/Issue_Files, helping ensure Maven release builds work from a clean clone without relying on generated output artifacts.

Changes:

  • Switch Java library smoke tests to tracked XLSX/DOCX fixtures and update assertions accordingly.
  • Switch Java CLI tests to the same tracked fixtures for consistent end-to-end coverage.
File summaries
File Description
minipdf-java/minipdf/src/test/java/io/github/minisoftware/minipdf/ClassicFixtureSmokeTest.java Uses tracked fixtures for XLSX/DOCX smoke conversions and validates expected text is present in produced PDFs.
minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java Updates CLI tests to use tracked fixtures for XLSX/DOCX conversion paths (and related option-validation coverage).
Review details

Suppressed comments (2)

minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java:36

  • This Path source declaration is over-indented; aligning it with surrounding statements keeps indentation consistent.
                Path source = REPOSITORY_ROOT.resolve("tests/Issue_Files/docx/Invoice.docx");

minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java:62

  • This line is indented more than the rest of the method body; it looks unintentional and should be aligned with other statements.
                Path source = REPOSITORY_ROOT.resolve("tests/Issue_Files/xlsx/Simple invoice1.xlsx");
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

void convertsXlsxWithDirectSyntax() throws Exception {
Path source = REPOSITORY_ROOT.resolve(
"tests/MiniPdf.Scripts/output/classic01_basic_table_with_headers.xlsx");
Path source = REPOSITORY_ROOT.resolve("tests/Issue_Files/xlsx/Simple invoice1.xlsx");
@shps951023
shps951023 merged commit a22eeeb into main Sep 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants