Use tracked fixtures in Java release tests - #128
Conversation
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The functional changes align with the PR goals and the only remaining findings are minor indentation issues in updated test lines.
Pull request overview
This PR updates the Java library and CLI smoke tests to use Git-tracked XLSX/DOCX fixtures under tests/Issue_Files, helping ensure Maven release builds work from a clean clone without relying on generated output artifacts.
Changes:
- Switch Java library smoke tests to tracked XLSX/DOCX fixtures and update assertions accordingly.
- Switch Java CLI tests to the same tracked fixtures for consistent end-to-end coverage.
File summaries
| File | Description |
|---|---|
| minipdf-java/minipdf/src/test/java/io/github/minisoftware/minipdf/ClassicFixtureSmokeTest.java | Uses tracked fixtures for XLSX/DOCX smoke conversions and validates expected text is present in produced PDFs. |
| minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java | Updates CLI tests to use tracked fixtures for XLSX/DOCX conversion paths (and related option-validation coverage). |
Review details
Suppressed comments (2)
minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java:36
- This
Path sourcedeclaration is over-indented; aligning it with surrounding statements keeps indentation consistent.
Path source = REPOSITORY_ROOT.resolve("tests/Issue_Files/docx/Invoice.docx");
minipdf-java/minipdf-cli/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java:62
- This line is indented more than the rest of the method body; it looks unintentional and should be aligned with other statements.
Path source = REPOSITORY_ROOT.resolve("tests/Issue_Files/xlsx/Simple invoice1.xlsx");
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| void convertsXlsxWithDirectSyntax() throws Exception { | ||
| Path source = REPOSITORY_ROOT.resolve( | ||
| "tests/MiniPdf.Scripts/output/classic01_basic_table_with_headers.xlsx"); | ||
| Path source = REPOSITORY_ROOT.resolve("tests/Issue_Files/xlsx/Simple invoice1.xlsx"); |
Summary
Validation
git diff --checkpassed