Repository navigation
test(build): add missing io import in builder_test.go - #679
Merged
Merged
Conversation
The second commit of #592 moved recordingStrategy into builder_test.go. The helper uses io.Reader and io.Copy, but the file does not import io. As a result, go vet and golangci-lint fail on main with "undefined: io", and the Lint and CI workflows for commit 10a428a are red. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
bergwolf
approved these changes
Oct 10, 2026
aftersnow
added a commit
that referenced
this pull request
Oct 10, 2026
Same fix as #679. The recordingStrategy helper merged from main uses io.Reader and io.Copy without importing io, which breaks go vet and golangci-lint on this branch. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
This was referenced Oct 10, 2026
aftersnow
added a commit
that referenced
this pull request
Oct 10, 2026
Same fix as #679. The recordingStrategy helper merged from main uses io.Reader and io.Copy without importing io, which breaks go vet and golangci-lint on this branch. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The second commit of #592 moved the
recordingStrategyhelper intopkg/backend/build/builder_test.go. The helper usesio.Readerandio.Copy. The file does not importio.As a result,
go vetand golangci-lint fail onmainwith this error:The Lint and CI workflows for commit 10a428a are red.
Fix
Add
"io"to the import block ofbuilder_test.go. No other change.Verification