Skip to content

FCD from fcd_torch - #29

Merged
zhebrak merged 13 commits into
molecularsets:masterfrom
danpol:fcd
Feb 11, 2019
Merged

FCD from fcd_torch#29
zhebrak merged 13 commits into
molecularsets:masterfrom
danpol:fcd

Conversation

@danpol

@danpol danpol commented Feb 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. Uses faster FCD implementation from fcd_torch
  2. Removed all dependencies from Keras/Tensorflow in package
  3. flake8 for metrics for further CI code style tests
  4. Removed all dependencies from Keras/Tensorflow from Dockerfile
  5. Save config and vocab before training to have functional checkpoints if training crashes

@danpol

danpol commented Feb 8, 2019

Copy link
Copy Markdown
Collaborator Author

Resolves #28

shayakhmetov
shayakhmetov reviewed Feb 11, 2019
View reviewed changes
Comment thread moses/metrics/metrics.py Outdated
shayakhmetov
shayakhmetov reviewed Feb 11, 2019
View reviewed changes
Comment thread moses/metrics/metrics.py Outdated
zhebrak
zhebrak previously approved these changes Feb 11, 2019
View reviewed changes
shayakhmetov
shayakhmetov previously approved these changes Feb 11, 2019
View reviewed changes
@zhebrak
zhebrak merged commit 2b613a0 into molecularsets:master Feb 11, 2019
@danpol
danpol deleted the fcd branch February 13, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shayakhmetov shayakhmetov shayakhmetov left review comments
+1 more reviewer
@zhebrak zhebrak zhebrak left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danpol @zhebrak @shayakhmetov