chore: add more accuracy models via Grove MCP-491#1140
Open
nirinchev wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the accuracy test runner to use Grove-backed LLM models (plus Anthropic via Grove), adds a model allowlist mechanism, and adjusts accuracy test infrastructure/scripts to better support local and CI runs.
Changes:
- Replace direct OpenAI/Gemini accuracy models with multiple Grove-backed models and add optional
MDB_ACCURACY_MODEL_ALLOWLISTfiltering. - Adjust the accuracy test client process environment handling and disk result status updates.
- Update scripts/workflows/editor config to support the new providers and higher test concurrency.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/accuracy/sdk/models.ts | Switches to Grove-backed model providers, adds allowlist-based model filtering. |
| tests/accuracy/sdk/accuracyTestingClient.ts | Strips MDB_MCP_* env vars when spawning the test server process. |
| tests/accuracy/sdk/accuracyResultStorage/diskStorage.ts | Avoids updating run status when the results file doesn’t exist. |
| tests/accuracy/createDeployment.test.ts | Loosens expected matcher for imageTag parameter. |
| scripts/accuracy/runAccuracyTests.sh | Documents Grove env vars/allowlist and increases Vitest worker count. |
| package.json | Adds @ai-sdk/anthropic dev dependency. |
| pnpm-lock.yaml | Locks @ai-sdk/anthropic and related transitive dependencies. |
| .vscode/launch.json | Adds a VS Code launch config for debugging accuracy tests. |
| .github/workflows/accuracy-tests.yml | Switches CI accuracy runs to use MDB_GROVE_API_KEY instead of OpenAI/Gemini keys. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Collaborator
Coverage Report for CI Build 25323040638Warning No base build found for commit Coverage: 81.733%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
1 task
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds some Grove-backed models for the accuracy test runner to use.