Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure move of two array equality helpers from the frontend into the shared util package; all call sites re-imported. No logic change.
Re-pointed imports (
../utils/arrays→@monkeytype/util/arrays):config/metadata.tsx,ui/SlimSelect.tsx,modals/EditResultTagsModal.tsx,modals/CommandlineModal.tsx(merged with its existingintersectimport),modals/MobileTestConfigModal.tsx,pages/settings/custom-setting/CustomPolyglot.tsx,pages/settings/custom-setting/CustomLayoutfluid.tsx,pages/test/TestConfig.tsx,controllers/challenge-controller.ts, plus the oneArrays.areSortedArraysEqualnamespace call incontrollers/theme-controller.ts.Evidence
frontend/src/ts/utils/arrays.ts, duplicated by consumers of the package (intersectalready lives in@monkeytype/util/arrays).After: single home in the package;
pnpm ts-check(8 workspaces),pnpm lint(15 tasks),pnpm build(8 tasks) andpnpm test(14 tasks, incl. frontend 1867 tests) all green.Merge Danger
Door: two-way
Mechanical move with identical implementations; reverting the commit restores the previous layout.
Blast Radius: small
Frontend-only;
@monkeytype/utilis already a frontend dependency and the functions are byte-for-byte the same, so no behavior or bundle-graph change.