Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/THEMES.md: new "How your CSS interacts with the core styles" section — core styles compile into@layer custom-styles(frontend/src/styles/index.scss) while theme files are unlayered, so any theme rule wins over the core regardless of specificity. Error-display rules must therefore self-guard with:not([data-ui-blind])(worked example + thedata-ui-*hooks#words/words/letters expose).docs/CONTRIBUTING.md: one Theme Guidelines bullet — safe in blind mode.frontend/package.json: lint-staged now runspnpm exec stylelinton staged*.scss/css. The rootlint-stagedconfig already has this entry, but husky runs the hook from the directorygit commitis invoked in, and lint-staged picks the nearest config — so commits made fromfrontend/(where agents work) used the frontend config, which lacked it, and stylelint was silently skipped.AGENTS.md: pointer topnpm lint-styles.Evidence
frontend/: the task ran (*.{scss,css} — 1 file→pnpm exec stylelint), a formatter-unfixable violation (no-duplicate-properties) failed it and aborted the commit, and an oxfmt-fixable one (property-case) was auto-fixed before it ran. Scratch branch deleted after the test.pnpm lint-stylespasses on master (exit 0), so the entry adds no new failures.Merge Danger
Two-way. Docs plus one lint-staged entry; the entry runs the same stylelint config CI already enforces, so it can only surface earlier what CI would catch.