Repository navigation
Fixed animetosho xyz matching the season of releases named for another season - #3689
Merged
morpheus65535 merged 1 commit intoOct 28, 2026
Conversation
…r season AnimeTosho files some later season releases under an earlier season's AniDB episode id (e.g. Mashle S02E11 listed for S01E11). Only assume the season matches when no parsed release name explicitly names a different one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
@anderson-oki you want to take a look at this one please? |
anderson-oki
approved these changes
Oct 27, 2026
Author
|
yipeeeee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3688
Bugs found
Found while debugging missing anime subtitles on v1.6.2:
eid=267727) returns mostlyS02E11releases.get_matchesalways addsseason, so these score like correct releases (62) and can be downloaded automatically.animetosho:feed.animetosho.orgis NXDOMAIN, so every request fails. Not fixed here: the provider is deprecated ([Provider] AnimeTosho feed returns HTTP 429 and service shutdown notice #3568).animetosho: the attachment host moved (storage.animetosho.orgis NXDOMAIN). AnimeTosho.xyz already uses the per-attachmenturl.animetosho: attachment language moved fromlangtolanguage_code. AnimeTosho.xyz already readslanguage_code.animetosho: the anidb refiner provides(anidb_series_id, anidb_episode_id), and the provider sent both aseid, so the feed returned[]. AnimeTosho.xyz already unpacks the tuple.Change
AnimeToshoXYZSubtitle.get_matchesstill always addsseriesandepisode. It now addsseasononly when no parsed release name (torrent name or file names) explicitly names a different season than the video.Mashle S02E11for S01E11: no season match, so it scores lower and drops below a typical minimum score.Mashle Magic And Muscles - 11(no season in the name): unchanged, season assumed from the AniDB episode id.This demotes candidates instead of filtering them out. Shows whose TVDB season numbering differs from the release numbering stay listed and can still be picked manually.
Tests
Added parametrized cases to
tests/subliminal_patch/test_animetosho_xyz.pycovering two S02 names, one S01 name and one name without a season.