Skip to content

Bug 2049263 - Add LoginsBridgedEngine to expose logins sync to Desktop - #7439

Merged
jo merged 2 commits into
mozilla:mainfrom
jo:bug-2049263
Jun 23, 2026
Merged

Bug 2049263 - Add LoginsBridgedEngine to expose logins sync to Desktop#7439
jo merged 2 commits into
mozilla:mainfrom
jo:bug-2049263

Conversation

@jo

@jo jo commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

https://bugzilla.mozilla.org/show_bug.cgi?id=2049263

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mhammond mhammond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks perfect

@jo
jo enabled auto-merge June 22, 2026 19:13
@jo
jo added this pull request to the merge queue Jun 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jun 22, 2026
Tessa Heidkamp and others added 2 commits June 23, 2026 11:26
…p via UniFFI

Co-Authored-By: Johannes Salas Schmidt <joschmidt@mozilla.com>
Co-Authored-By: Krist Baliev <kbaliev@mozilla.com>
The Rust logins sync engine now skips the chrome://FirefoxAccounts FxA-login
when collecting outgoing records, matching the exclusion the JS PasswordEngine
does on Desktop. Without this, the FxA session credentials would be uploaded
once Desktop syncs logins through the bridged engine.
@jo
jo added this pull request to the merge queue Jun 23, 2026
Merged via the queue into mozilla:main with commit e9d4077 Jun 23, 2026
14 checks passed
@jo
jo deleted the bug-2049263 branch June 23, 2026 10:15
adudenamedruby pushed a commit to adudenamedruby/application-services that referenced this pull request Jul 8, 2026
…ro. (mozilla#7464)

Seeing mozilla#7439 fly past reminded me that I was intending to try and remove the
BridgedEngine entirely - this doesn't quite achieve that, but does get closer.
jonesetc pushed a commit to jonesetc/application-services that referenced this pull request Aug 12, 2026
…ro. (mozilla#7464)

Seeing mozilla#7439 fly past reminded me that I was intending to try and remove the
BridgedEngine entirely - this doesn't quite achieve that, but does get closer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants