Bug 1868418 - Rerun ensure capabilities after logging in

[bendk]

Moved the code to RetryingAccount, which should give us this functionality for free.

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

[bendk]

I think I got the state machine stuff right, but please double-check my work here.

[skhamis]

Nice fix! I think we're close but just one question about the error part

[skhamis]

One thing worth checking: in the old code we land at S::AuthIssues when check_authorization_status comes back false. The new code propagates the original FxaError::Authentication to the Err(cause) arm, which sends us to S::Disconnected?. For someone who is signed-in and whose refresh token is server-invalidated (password-changed elsewhere), I think our AuthIssues preserves the account state and lets consumers show the "re-auth" flow. Disconnected will put them back to full sign-in right?
Should we do something like:

 match account.finish_initialize(&device_config.capabilities) {
                         Ok(()) => Ok(S::Connected),
                        Err(cause) => {
                            let target = if matches!(cause.get_error_handling().err, FxaError::Authentication) {
                                S::AuthIssues
                            } else {
                                S::Disconnected
                            };
                            Err(StateMachineErr::new(cause, target))
                        }
                    }

or something similar? However if i'm missing something here please let me know!

[bendk]

That seems like an improvement, but maybe it should always be S::AuthIssues. I think that's what the current code does and it seems more correct to me. WDYT?

[skhamis]

Thanks for making that change. I agree with the new direction and think its "more correct". LGTM!

[bendk]

Dependency checks seem unrelated to this PR, I didn't change Cargo.lock at all. I'm going to hit the merge button anyways.