Skip to content

Reference UNIFFI_META_* symbols in the megazord stub so the linker keeps them - #7498

Merged
ahochheiden merged 1 commit into
mainfrom
megazord-stub-uniffi-meta
Jul 30, 2026
Merged

Reference UNIFFI_META_* symbols in the megazord stub so the linker keeps them#7498
ahochheiden merged 1 commit into
mainfrom
megazord-stub-uniffi-meta

Conversation

@ahochheiden

@ahochheiden ahochheiden commented Jul 27, 2026

Copy link
Copy Markdown
Member

This necessary for the application-services monorepo work in Firefox. Full stack on Phabricator here: https://phabricator.services.mozilla.com/D313317

@ahochheiden
ahochheiden requested a review from mhammond July 27, 2026 00:07

@mhammond mhammond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the existing pattern work here? All this code is solving the exact same problem, and what I hate about this version is that it looks like every public api change is going to need an entry here which is going to regularly shoot people's toes off.

@ahochheiden

Copy link
Copy Markdown
Member Author

Does the existing pattern work here? All this code is solving the exact same problem, and what I hate about this version is that it looks like every public api change is going to need an entry here which is going to regularly shoot people's toes off.

I agree this is not optimal, but the checksum trick doesn't work for most of the entries I added because they're data only.

We could maybe use --whole-archive or codegen-units=1 to get around this approach entirely, but I haven't thought through all of the consequences with those approaches (We do codegen-units=1 for Release on Firefox, and it's a huge (in the 20x range) build time regression.

Base automatically changed from uniffi-kotlin-from-mozconfig to main July 28, 2026 00:32
@ahochheiden
ahochheiden force-pushed the megazord-stub-uniffi-meta branch from 4629183 to 7603509 Compare July 28, 2026 20:13
@ahochheiden
ahochheiden requested a review from a team as a code owner July 28, 2026 20:13
@ahochheiden
ahochheiden requested review from copyrighthero and removed request for a team July 28, 2026 20:13
@ahochheiden

Copy link
Copy Markdown
Member Author

Hmm, I seem to have irreparably merged these unintentionally by trying to change the order...

@ahochheiden
ahochheiden changed the base branch from main to normalize-groupid-nested-gradle July 28, 2026 20:32
@ahochheiden
ahochheiden force-pushed the normalize-groupid-nested-gradle branch from 88d7e4f to 68506e1 Compare July 29, 2026 20:32
Base automatically changed from normalize-groupid-nested-gradle to main July 29, 2026 22:27
@ahochheiden
ahochheiden force-pushed the megazord-stub-uniffi-meta branch from 7603509 to 348a886 Compare July 30, 2026 04:35

@mhammond mhammond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate it but have no better ideas :)

@ahochheiden
ahochheiden added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit cec9c5e Jul 30, 2026
14 checks passed
@ahochheiden
ahochheiden deleted the megazord-stub-uniffi-meta branch July 30, 2026 05:21
jonesetc pushed a commit to jonesetc/application-services that referenced this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants