Skip to content

Implement SyncEngine::wipe for the logins engine - #7515

Merged
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-vkusnsuxxqnr
Jul 30, 2026
Merged

Implement SyncEngine::wipe for the logins engine#7515
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-vkusnsuxxqnr

Conversation

@mhammond

@mhammond mhammond commented Jul 30, 2026

Copy link
Copy Markdown
Member

I think this is all we (theoretically) need to stop bug 2058915 - but it needs to be vendored into m-c, and that's apparently broken at the moment.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mhammond
mhammond requested a review from jo July 30, 2026 04:29
@mhammond
mhammond added this pull request to the merge queue Jul 30, 2026
lando-worker Bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Jul 30, 2026
@mhammond
Bug 2058915 - vendor logins-wipe-crash app-services branch. r=joschmidt
ee1b309 
Vendoring main is currently broken in multiple ways. The logins-wipe-crash
branch is what's currently in m-c plus
mozilla/application-services#7515.

Differential Revision: https://phabricator.services.mozilla.com/D315224
Merged via the queue into mozilla:main with commit 1dfe8ac Jul 30, 2026
14 checks passed
@mhammond
mhammond deleted the push-vkusnsuxxqnr branch July 30, 2026 08:36
jo pushed a commit that referenced this pull request Jul 30, 2026
@mhammond @jo
Implement SyncEngine::wipe for the logins engine (#7515)
03ef316
jonesetc pushed a commit to jonesetc/application-services that referenced this pull request Aug 12, 2026
@mhammond @jonesetc
Implement SyncEngine::wipe for the logins engine (mozilla#7515)
dfd981f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jo jo jo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhammond @jo