Skip to content

Bug 2058816 - updating get_base_url and get_url in remote_settings to append v2 - #7517

Merged
alexcottner merged 3 commits into
mainfrom
rs-v2-fix
Jul 30, 2026
Merged

Bug 2058816 - updating get_base_url and get_url in remote_settings to append v2#7517
alexcottner merged 3 commits into
mainfrom
rs-v2-fix

Conversation

@alexcottner

@alexcottner alexcottner commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Correcting bug 2058816 by appending v2 in get_url and get_base_url in remote_settings/src/config.rs. This was missed during the v1 removal #7492 .

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@leplatrem
leplatrem self-requested a review July 30, 2026 15:35
@alexcottner
alexcottner marked this pull request as ready for review July 30, 2026 15:56
@alexcottner
alexcottner added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit d3107a0 Jul 30, 2026
14 checks passed
@alexcottner
alexcottner deleted the rs-v2-fix branch July 30, 2026 20:02
jonesetc pushed a commit to jonesetc/application-services that referenced this pull request Aug 12, 2026
@alexcottner @jonesetc
Bug 2058816 - updating get_base_url and get_url in remote_settings to…
5015a4d 
… append v2 (mozilla#7517)

* Bug 2058816 - updating get_base_url and get_url in remote_settings config to append v2 instead of v1 for custom url's

* Updating remote_settings unit tests

* updating search and nimbus-cli refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leplatrem leplatrem leplatrem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcottner @leplatrem