Repository navigation
Minimize thread numbers for the client - #2716
Closed
badumbatish wants to merge 1 commit into
Closed
badumbatish wants to merge 1 commit into
badumbatish wants to merge 1 commit into
Conversation
Minimize thread numbers for the client, its querying only after all. This commit doesn't try to limit the thread size to 1. I was worried that there might be some hidden interacts that might lead to deadlock.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
==========================================
- Coverage 74.41% 74.33% -0.08%
==========================================
Files 70 70
Lines 39211 39377 +166
==========================================
+ Hits 29177 29270 +93
- Misses 10034 10107 +73 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
i think #2704 might be solving for the same issue. I'd love to have the PR merged |
Collaborator
|
#2704 has been merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimize thread numbers for the client, its querying only after all.
This commit doesn't try to limit the thread size to 1. I was worried that there might be some hidden interacts that might lead to deadlock but would be very glad to be enlightened on this