ci: Drop the unused build-artifact cache - #178
Merged
Merged
Conversation
The build job saved bin/ and obj/ to a cache that no job restored: every test job restores and rebuilds its own project. Three measured options for #144 item 3, three runs each by workflow_dispatch: - Rebuild per project without the cache step: 2.9 min, 10.2 runner-min. - Share the build output and run tests with --no-build: 3.8 min, 10.3 runner-min. Packing and downloading 164 MB cancels the saved builds, and the jobs still need a package restore. - One test job running every project: 4.4 min, 4.2 runner-min. - For comparison, main as it was: 3.7 min, 10.6 runner-min. All passed every run, so this keeps the matrix, drops the cache step, and notes why on the test job. Refs #144 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change removes an unrestored cache without altering required build or test behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Removes an unused CI build-output cache while retaining per-project test builds.
Changes:
- Removes caching of
bin/andobj/. - Documents why test matrix jobs rebuild independently.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Simplifies CI caching and documents the tested approach. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 77 77
Lines 1596 1596
Branches 150 150
=======================================
Hits 1363 1363
Misses 189 189
Partials 44 44 |
mpaulosky
added a commit
that referenced
this pull request
Sep 30, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mpaulosky
added a commit
to mpaulosky/atelier-store
that referenced
this pull request
Sep 30, 2026
The build job cached bin/ and obj/ after building, but no test job ever restored that cache: each matrix job restores and builds its own project. The step cost 5-8s per build and held about 1.1 GB of the repo's Actions cache. A comment on the test job records why the matrix stays without a shared build (measured in mpaulosky/IssueTracker#144). Port of mpaulosky/IssueTracker#178. Refs #86 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item 3 of #144. The build job saved
bin/andobj/to a cache that no job ever restored, because every test job restores and rebuilds its own project. This removes that step and leaves a comment on the test job explaining why the matrix rebuilds.How the option was chosen
Each option ran 3 times by
workflow_dispatch, one run at a time, on its own branch:mainas it was--no-build--no-buildskips compiling but the test host and Blazor static web assets still load files from.nuget/packages; its first run failed without them.Testing
yamllint,actionlintandzizmorare clean, andscripts/gate.shpassed.Refs #144 (atelier-store still to follow).
🤖 Generated with Claude Code