test(hooks): Test uppercase slugs apart from the chore/ digit rule - #186
Merged
Merged
Conversation
chore/7-Upper was refused for its leading digit, so it never tested the lowercase rule on its own. feature/9-Upper and chore/tidy-Up do; a hook that allowed uppercase fails both. Found by review of the same test's port to mpaulosky/atelier-store#92. Refs #144 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The new cases accurately isolate lowercase-slug enforcement without reducing existing coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Strengthens pre-push branch-name tests so uppercase slug validation is isolated from other naming rules.
Changes:
- Adds independent uppercase tests for feature and chore branches.
- Retains separate digit-leading chore coverage.
| File | Description |
|---|---|
.github/hooks/tests/pre-push.test.sh |
Refines invalid branch-name test cases. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 77 77
Lines 1596 1596
Branches 150 150
=======================================
Hits 1363 1363
Misses 189 189
Partials 44 44 |
Contributor
mpaulosky
added a commit
that referenced
this pull request
Sep 30, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The branch-standard tests (#182) used
chore/7-Upperas the uppercase case, but the hook refuses it for its leading digit anyway, so it never tested the lowercase rule on its own. Copilot caught this in the same test's port to mpaulosky/atelier-store#92. It's replaced byfeature/9-Upperandchore/tidy-Up, which each break only the lowercase rule, whilechore/7-cleanupstill covers the digit-leading one.Testing
pre-push.test.sh: 48 passed, 0 failed.shellcheckis clean, and the pre-push gate passed.Refs #144
🤖 Generated with Claude Code