Skip to content

ci(release): List again every 2s, for up to 30s #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpaulosky merged 1 commit into from
Sep 30, 2026
Merged

ci(release): List again every 2s, for up to 30s #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/scripts/backfill_blog_posts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@

GitHub's release list can lag a just-published Release by several seconds,
so with --wait-for-prs it lists again until every named PR has a Release,
for up to a minute. A PR whose release failed never appears; after the last
attempt the run writes what is listed, and the next run picks up the rest.
every 2s for up to half a minute. A PR whose release failed never appears;
after the last attempt the run writes what is listed, and the next run
picks up the rest.
"""

import argparse
Expand All @@ -42,8 +43,8 @@ def parse_pr_numbers(text):
return {int(n) for n in numbers}


WAIT_ATTEMPTS = 12
WAIT_DELAY = 5
WAIT_ATTEMPTS = 15
WAIT_DELAY = 2


def listed_releases(gh, wait_for=None, attempts=WAIT_ATTEMPTS, delay=WAIT_DELAY, sleep=time.sleep):
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ jobs:
run: |
# The release list can lag a Release published seconds ago, so name
# the PRs this run released: the script lists again until each has
# one, for up to a minute.
# one, for up to half a minute.
python3 .github/scripts/backfill_blog_posts.py --wait-for-prs "$(jq -r 'join(",")' <<< "${QUEUE:-[]}")"

# git status (not git diff) so brand-new, still-untracked files count.
Expand Down
Loading