💄 Liquid glass icons for AppIcon-Classic and AppIcon-Developer#810
Merged
Conversation
# Conflicts: # Loop/Luminare/LuminareManager.swift # Conflicts: # Loop/Extensions/Notification+Extensions.swift # Loop/Luminare/LuminareManager.swift # Loop/Managers/KeybindMonitor.swift # Loop/Managers/LoopManager.swift # Loop/Radial Menu/RadialMenuView.swift # Loop/Window Action Indicators/Radial Menu/RadialMenuViewModel.swift
mrkai77
changed the title
AppIcon-Classic and AppIcon-DeveloperAppIcon-Classic and AppIcon-Developer
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two icons with Liquid Glass support:
AppIcon-ClassicandAppIcon-Developer. They are directly based off of their non-Liquid Glass alternatives.Currently, only the icon initially built with the app itself (Classic for stable builds, Developer for beta builds) can fully support Liquid Glass. All other icons fall back to a pre-rendered PNG instead. To make this clearer, this PR introduces an indicator that shows which icon supports Liquid Glass.
