Repository navigation
[composite] Always skip natively disabled items during list navigation - #5185
Merged
Merged
Conversation
commit: |
Bundle size
PerformanceTotal duration: 990.04 ms +150.60 ms(+17.9%) | Renders: 78 (+0)
…and 1 more (+8 within noise) — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
July 8, 2026 10:43
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
July 8, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isListIndexDisabledlet adisabledIndicesoverride mark natively disabled elements as enabled.Tabs.Listpasses an emptydisabledIndicesso that disabled tabs stay focusable, but that also applied to elements carrying a nativedisabledattribute, e.g.<Tabs.Tab render={<button disabled />} />. The composite moved its active index onto such a tab and thefocus()call silently failed, leaving keyboard navigation stuck: pressing ArrowRight from tab A focused A again, and only the next press reached C.Natively disabled elements can never receive focus, so
isListIndexDisablednow always skips them, regardless ofdisabledIndices.aria-disableditems are unaffected and remain focusable while disabled (the APG default). Menu and Select pass the same override, so the same applies there; tests cover Tabs and Menu. This also means both APG conventions are now reachable: thedisabledprop keeps an item in the focus order, while rendering a natively disabled element removes it.Closes #5132