You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
OAuth request elements are duplicated in the API console and API request panel #678
Current examples of element and standalone API console include oauth1-authorization and oauth2-authorization handlers in both, the API console and the api-request-editor component which results in OAuth-related request events fired twice.
Expected outcome
OAuth request handlers should be included in either the API console or the request editor.
Actual outcome
OAuth request handlers included in both elements.
Steps to reproduce
Clone the git repo, run npm i and npm start after the installation.
In the opened browser tab, open the "API console as a standalone application" link or the "API console as a web component" link.
Open any API endpoint method and open the request panel.
Inspect the page code in browser's developer tools and search for <oauth2-authorization. See two entries instead of only one.
changed the title [-]OAuth request elements are duplicated in the API console itself and request panel[/-][+]OAuth request elements are duplicated in the API console and API request panel[/+]on Mar 8, 2021
Any progress on this issue? It's just about removing it from one place or another, and rate limits are no joke in some cases.
I workarounded this by overriding it with my own _helpersTemplate() in the extending class, but still I guess it should be up to implementer, not the request panel.
These 2 components should only be included in the api-console-app. For any other use case they should be included separately or the events should be handled by the hosting application. @twoplustwoone can you please take a look?
Activity
[-]OAuth request elements are duplicated in the API console itself and request panel[/-][+]OAuth request elements are duplicated in the API console and API request panel[/+]deiteris commentedon Aug 15, 2021
Any progress on this issue? It's just about removing it from one place or another, and rate limits are no joke in some cases.
I workarounded this by overriding it with my own
_helpersTemplate()in the extending class, but still I guess it should be up to implementer, not the request panel.jarrodek commentedon Aug 16, 2021
These 2 components should only be included in the
api-console-app. For any other use case they should be included separately or the events should be handled by the hosting application. @twoplustwoone can you please take a look?